Bug 161728 - [Decorators] Decoration should be turned off for periods when it is flooded with requests
Summary: [Decorators] Decoration should be turned off for periods when it is flooded w...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-10-20 10:52 EDT by Andre Costa CLA
Modified: 2021-10-14 09:43 EDT (History)
0 users

See Also:


Attachments
Screenshot of Eclipse task list (79.09 KB, image/png)
2006-10-20 10:55 EDT, Andre Costa CLA
no flags Details
GKrellm showing CPU usage and load while Eclipse loops (35.42 KB, image/png)
2006-10-20 10:56 EDT, Andre Costa CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Costa CLA 2006-10-20 10:52:36 EDT
Sometimes after I refresh my source tree (eg. after I update it outside eclipse using command-line SVN) eclipse loops forever on a system task labeled "System: Decoration Calculation - Calculating Decorations: Decorating" (see attached screenshot for an example).

When this happens, eclipse eats lots of CPU (50-100%) (gkrellm shows load average of 2.5 -- screenshot attached). Cancelling "build workspace" task is ineffective, and only option is kill Eclipse -- which sometimes doesn't help at all because problem resumes as soon as eclipse restarts.
Comment 1 Andre Costa CLA 2006-10-20 10:55:28 EDT
Created attachment 52398 [details]
Screenshot of Eclipse task list
Comment 2 Andre Costa CLA 2006-10-20 10:56:20 EDT
Created attachment 52399 [details]
GKrellm showing CPU usage and load while Eclipse loops
Comment 3 Tod Creasey CLA 2006-10-20 12:50:12 EDT
Is this just with the SDK or do you have other plug-ins? also which decorators are enabled?

If we get constant decoration requests from viewers this is likely to happen so we need to know which viewers and which decorators are enabled.

A way to test the issue is to close viewers or turn off decorators one by one until the problem stops.
Comment 4 Andre Costa CLA 2006-10-20 13:08:04 EDT
Hi Tod,

my installation is minimal for my needs: eclipse-platform, eclipse-JDT, subclipse plugin (1.0.3 -- version 1.1.x is still too buggy to be used).

... I don't really know what decorators are, sorry =) (first time I heard of it was when I traced the source of the problem at hand) So: what are they, and how do I turn them off? (I will try closing views anyway whenever it happens again).
Comment 5 Tod Creasey CLA 2006-10-20 13:50:30 EDT
Look in Preferences->Label Decorations you can enable or disable them there. I am suspicious of your repository provider.
Comment 6 Andre Costa CLA 2006-10-20 14:48:57 EDT
Thks, found it. Yes, it could be SVN related -- it has been reported by one of my coworkers that disabling/removing subclipse solved the problem at least once. This is obviously not a solution...

But, what do you mean exactly? I mean, what could be the problem? It's a SVN server v1.3.2, I guess, running on Linux, and I am accessing repository through HTTPS. Could it be SVN fault? Even if so, shouldn't eclipse handle it in a more graceful manner?
Comment 7 Tod Creasey CLA 2006-10-20 15:23:18 EDT
The problem is that they are flooding us with decoration requests due to constant label updates.

We could implement something that turns decoration off if the DecoratorManager is flooded - I'll update the problem report title to reflect this.

It is still an issue for Subclipse regardless - even with our decorations turned off they must be spending a lot of time in redundant label processing.
Comment 8 Andre Costa CLA 2006-10-20 15:56:14 EDT
Mmmh... ok, now I see. Makes sense.

I agree that making DecoratorManager more robust with regards to requests floods should make eclipse usable again under such circumstances. Also, the updated report title now makes more sense indeed.

I am not sure I agree with severity changing to "enchancement", though -- as far as user perception goes eclipse is looping forever when this happens, and the only way to get out of it (aside from waiting "forever") is killing it. This doesn't sound like something that should only be "enhanced" (even though the cause of the problem is not eclipse itself but one of its plugins). Just my $0.02...

Also, how should we deal with this regarding subclipse? Should I open a bug report with them about it? Will you guys do it? They should be focusing on the upcoming version 1.1.x, but hopefully they either release it as stable or fix the problem on 1.0.x trunk.
Comment 9 Tod Creasey CLA 2006-10-20 16:02:33 EDT
Makes sense
Comment 10 Kevin McGuire CLA 2009-04-16 18:17:12 EDT
(In reply to comment #8)

> Also, how should we deal with this regarding subclipse? Should I open a bug
> report with them about it? 

Please open a bug against subclipse thanks.

I agree it'd be good to throttle bad plugins abusing updating.  Tricky problem and not for time remaining in 3.5.
Comment 11 Boris Bokowski CLA 2009-11-17 10:54:28 EST
Oleg is now responsible for watching the [Decorators] category.
Comment 12 Eclipse Webmaster CLA 2019-09-06 16:11:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 13 Eclipse Genie CLA 2021-10-14 09:43:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.