Description John O'Shea 2006-10-14 09:04:28 EDT

LinkedResourceDecorator.decorate() always decorates links to non-local filestore URIs with a warning decoration (in the bottom right corner).  

The implementation of this method uses IResource.getLocation() which returns null for non-local filestore URIs, causing the subsequent if() to add the warning decoration:

IPath location = resource.getLocation();

if (location != null && location.toFile().exists()) {
	decoration.addOverlay(LINK);
} else {
	decoration.addOverlay(LINK_WARNING);
}

Perhaps it should use IResource.getLocationURI() and an EFS API (EFS.getStore(URI).fetchInfo().exists()) rather than location.toFile().exists() to determine if the resource actually exists?

To reproduce:

To reproduce this:

1) Install a non-local filesystem EFS extension.  The example below uses the
HTTP IFileStore implementation listed at
http://wiki.eclipse.org/index.php/EFS#HTTP

2) Create a project with the following descriptor (.project file):

<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
        <name>linktest</name>
        <comment></comment>
        <projects>
        </projects>
        <buildSpec>
        </buildSpec>
        <natures>
        </natures>
        <linkedResources>
                <link>
                        <name>index.html</name>
                        <type>1</type>
                       
<locationURI>http://www.eclipse.com/index.html</locationURI>
                </link>
        </linkedResources>
</projectDescription>

Note the warning icon in the bottom right corner of the link resource.