Bug 160748 - ConfigurationParser.parse does unbuferred I/O from disk
Summary: ConfigurationParser.parse does unbuferred I/O from disk
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Branko Tripkovic CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-10-12 16:29 EDT by John Arthorne CLA
Modified: 2007-01-15 14:57 EST (History)
5 users (show)

See Also:

Attachments
patch for update.configurator (13.38 KB, patch)
2006-11-30 16:22 EST, DJ Houghton CLA 		no flags Details | Diff
patch for update.configurator (1.77 KB, patch)
2007-01-09 15:40 EST, DJ Houghton CLA 		no flags Details | Diff
patch for update.configurator (1.66 KB, patch)
2007-01-10 11:31 EST, DJ Houghton CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2006-10-12 16:29:53 EDT 
This method uses new FileInputStream, but does not wrap the stream in a BufferedInputStream.  This means each byte read from the file requires a disk read.
Comment 1 Chris Laffra CLA 2006-10-12 17:20:55 EDT 
this happens during reading the configuration at startup, which we definitely want to do buffered, especially on a cold startup (such as after reboot).
Comment 2 DJ Houghton CLA 2006-11-30 16:22:48 EST 
Created attachment 54828 [details]
patch for update.configurator
Comment 3 DJ Houghton CLA 2006-11-30 16:26:22 EST 
Comment on attachment 54828 [details]
patch for update.configurator

Actually don't apply this patch...I have Eclipse set to auto format and organize imports when I save so there are too many changes here. 

All you need to do is change the 2 places in ConfigurationParser#parse.

Also there is the same case in FeatureParser#parse. It too should be wrapped in a BufferedInputStream.
Comment 4 DJ Houghton CLA 2006-12-11 16:12:34 EST 
Changing milestone to 3.3 M5 since patch didn't get released for M4.
Comment 5 DJ Houghton CLA 2006-12-12 10:04:58 EST 
Changing target milestone for consideration for 3.2.2.
Adding McQ to the CC list as a PMC representative for approval.
Comment 6 Mike Wilson CLA 2006-12-12 13:53:02 EST 
+1
Comment 7 Dejan Glozic CLA 2006-12-13 18:50:36 EST 
Branko, please release into the 3.2.2 release and also HEAD but don't version for the M4.
Comment 8 Steven Wasleski CLA 2007-01-09 10:04:04 EST 
With regard to comment 7, is this in the 3.2.2 builds yet?
Comment 9 Dejan Glozic CLA 2007-01-09 14:10:19 EST 
No. DJ, can you attach a new patch without formatting for ConfigurationParser and FeatureParser that I can apply today?
Comment 10 DJ Houghton CLA 2007-01-09 15:40:16 EST 
Created attachment 56660 [details]
patch for update.configurator

Patch for org.eclipse.update.configurator. Should work against both 3.2.x and HEAD streams.
Comment 11 DJ Houghton CLA 2007-01-10 11:31:49 EST 
Created attachment 56712 [details]
patch for update.configurator

better patch. ready for release. good for both streams.
Comment 12 Dejan Glozic CLA 2007-01-10 13:42:18 EST 
Branko, please release DJ's patch into both the maintenance and the HEAD streams (also version and update the maps).
Comment 13 Steven Wasleski CLA 2007-01-15 09:16:26 EST 
With regard to comment 12, did this make last Friday's 3.2.2 build?
Comment 14 Branko Tripkovic CLA 2007-01-15 10:36:35 EST 
yes this is in 3.2.2, but it is not closed since it is not in HEAD yet.
Comment 15 DJ Houghton CLA 2007-01-15 14:57:26 EST 
Created bug 170527 to track releasing this fix into 3.3.
Closing.