Comment 1 Perry James 2006-10-12 11:05:10 EDT

Created attachment 51858 [details]
update to generateParser.html

Here's a patch for the file howto/generate parser/generateParser.html from the jdt-core-home project. 

In addition to some minor edits, the three main changes are

    * a warning about the required line separator,
    * noted that only the java_1_5.g grammar file is supported,
    * added a step to update the TerminalTokens.java file.

Comment 2 Olivier Thomann 2006-10-12 11:14:00 EDT

Thanks. I'll check it later today.

Comment 3 Olivier Thomann 2006-10-12 13:44:03 EDT

I disagree with this part:
 Also make sure that the file has Unix-style end-of-line characters (i.e., not those of MS-DOS), as the parser generator is quite picky about this. 

It works perfectly fine even if Windows end-of-line characters are used.
The only thing that needs to be done if finishing the file with a new line.

Except this I am ready to release all other changes. ok for you? Could you please describe the errors you got using Windows end-of-line characters ?

Comment 4 Olivier Thomann 2006-10-12 14:56:24 EDT

Released for 3.3M3.
I skipped the sentence mentionned above as long as I don't have more details why it is required. It works for me without this.

Comment 5 Olivier Thomann 2006-10-12 15:06:14 EDT

I did a merge with what was released in the jdt.core web page (old file though).

Comment 6 David Audel 2006-10-30 06:09:11 EST

Verified for 3.3 M3 using build I20061030-0010