### Eclipse Workspace Patch 1.0
#P jdt-core-home
Index: howto/generate parser/generateParser.html
===================================================================
RCS file: /cvsroot/eclipse/jdt-core-home/howto/generate parser/generateParser.html,v
retrieving revision 1.6
diff -u -r1.6 generateParser.html
--- howto/generate parser/generateParser.html	26 Sep 2006 07:58:10 -0000	1.6
+++ howto/generate parser/generateParser.html	12 Oct 2006 14:54:48 -0000
@@ -29,7 +29,7 @@
 <tr>
 	<td ALIGN=RIGHT VALIGN=TOP WIDTH="2%"><img SRC="http://dev.eclipse.org/images/Adarrow.gif" NOSAVE BORDER=0 height=16 width=16></td>
 	<td WIDTH="98%"><b>Where to get the grammar</b><br>
-	<blockquote>The latest grammar is always located in the <code>java_1_5.g</code> file. Go to the org.eclipse.jdt.core plugins
+	<blockquote>The latest grammar is always located in the <code>java_1_5.g</code> file. (N.B.: Older versions of the grammar, such as java_1_4.g are not supported and are no longer functional.) Go to the org.eclipse.jdt.core plugins
 	directory (<font color="#3366FF">eclipse\plugins\org.eclipse.jdt.core</font> where eclipse is the root of your eclipse installation) and open the 
 	<font color="#3366FF">grammar</font> directory. Then search for the <font color="#3366FF">java_1_5.g</font> file inside the
 	folder <font color="#3366FF">grammar</font>. Then copy its contents from: 
@@ -40,7 +40,8 @@
 -- need a carriage return after the $end
 </PRE>
 	into a file called <font color="#3366FF">java.g</font>. It is important to add a carriage return at the end of the last line.
-	You can save this file where you want, we will assume from thereon you saved it in <code>d:\temp\</code>.
+	You can save this file where you want, we will assume from thereon you saved it in <code>d:\temp\</code>.  
+	Also make sure that the file has Unix-style end-of-line characters (i.e., not those of MS-DOS), as the parser generator is quite picky about this.
 	</blockquote>
 	</p>
 	</td>
@@ -49,7 +50,7 @@
 	<td ALIGN=RIGHT VALIGN=TOP WIDTH="2%"><img SRC="http://dev.eclipse.org/images/Adarrow.gif" NOSAVE BORDER=0 height=16 width=16></td>
 	<td WIDTH="98%"><b>What to do with these files and update the parser class...</b><br>
 	<blockquote>
-Assuming, the LPG executable (<code>lpg.exe</code> or <code>jikespg.exe</code>) is located inside <code>d:\lpg</code>.
+Assuming the LPG executable (<code>lpg.exe</code> or <code>jikespg.exe</code>) is located in <code>d:\lpg</code>.
  <ol>
  <li>First in a console, run:
  <PRE>
@@ -128,25 +129,25 @@
 
 Escaped symbol $error is an invalid C variable.
  </PRE>
- It can be quite different if the output changed since the version 2.30 of lpg. The important part is:<br>
+ It can be quite different if the output changed since version 2.30 of LPG. The important part is:<br>
  <blockquote><b>This grammar is LALR(1).</b></blockquote>
- This creates in the current directory some java source files and information files.
+ This creates some java source files and information files in the current directory.
  <blockquote><table BORDER=1 CELLSPACING=2 CELLPADDING=10>
  <tr>
  <th VALIGN=top align=left>java.l</th>
- <td VALIGN=top>Information generated by lpg/jikespg. Enumarate all the states created for the automaton, etc.</td>
+ <td VALIGN=top>Log information generated by lpg/jikespg. Enumarates all the states created for the automaton, etc.</td>
  </tr>
  <tr>
  <th VALIGN=top align=left>JavaAction.java</th>
- <td>It contains the method consumeRule(int) of the class org.eclipse.jdt.internal.compiler.parser.Parser that handles all semantic actions dispatches.</td>
+ <td>Contains the method consumeRule(int) of class org.eclipse.jdt.internal.compiler.parser.Parser, which handles all semantic action dispatches.</td>
  </tr>
  <tr>
 <th VALIGN=top align=left>javahdr.java</th>
- <td>This files is used to generate the resources files.</td>
+ <td>Used to generate the resources files.</td>
  </tr>
  <tr>
 <th VALIGN=top align=left>javadcl.java</th>
- <td>This files is used to generate the resources files.</td>
+ <td>Used to generate the resources files.</td>
  </tr>
  <tr>
 <th VALIGN=top align=left>javasym.java</th>
@@ -167,8 +168,9 @@
  <ol>
  <li>Copy the contents of the <font color="#3366FF">JavaAction.java</font> file into the <font color="#3366FF">consumeRule(int)</font> method of the org.eclipse.jdt.internal.compiler.parser.Parser class.
  </li>
- <li>The class <font color="#3366FF">org.eclipse.jdt.internal.compiler.parser.ParserBasicInformation</font> needs to be updated with the content of the file <font color="#3366FF">javadef.java</font>. Don't copy the 
+ <li>The class <font color="#3366FF">org.eclipse.jdt.internal.compiler.parser.ParserBasicInformation</font> needs to be updated with the contents of the file <font color="#3366FF">javadef.java</font>. Don't copy the 
  interface name. Simply copy the field declarations. The actual source of this class will guide you.</li>
+ <li>Similarly, update the class <font color="#3366FF">org.eclipse.jdt.internal.compiler.parser.TerminalTokens</font> with the contents of the file <font color="#3366FF">javasym.java</font>.
  <li>The last step is to update the resource files:<br>
  Copy the jdtcore.jar file in d:\temp. Compile this <A HREF="UpdateParserFiles.java">source</A> inside d:\temp. You will have a file UpdateParserFiles.class.
  Then run the following command-line: