Bug 159791 - [Preferences] PreferenceDialogUtil.createPropertyDialogOn should not restrict element to being an IAdaptable
Summary: [Preferences] PreferenceDialogUtil.createPropertyDialogOn should not restrict...
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Duong Nguyen CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2006-10-04 15:44 EDT by Nick Edgar CLA
Modified: 2007-06-13 16:28 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2006-10-04 15:44:18 EDT 
3.2

We have an object that has an associated property page, but the object is not an IAdaptable.  We currently have no proper API for opening the properties dialog on this object.  The closest I could find is PreferenceDialogUtil.createPropertyDialogOn, but the element argument is typed as IAdaptable.  I think this should be relaxed to allow an arbitrary Object.

We currently have a hack workaround whereby we have our own subclass of PropertyDialogAction (marked as not subclassable) with a custom selection provider that returns a selection with our object, and then run the action.  It would be nice to clean this up.
Comment 1 Tod Creasey CLA 2007-06-13 16:28:50 EDT 
There are currently no plans to work on this however I would be happy to look over a contribution