Bug 157943 - Wrong undo change bounds action in ADD
Summary: Wrong undo change bounds action in ADD
Status: ASSIGNED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EPF (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shashidhar Kannoori CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-20 01:05 EDT by Wilma Wang CLA
Modified: 2023-02-16 16:17 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wilma Wang CLA 2006-09-20 01:05:57 EDT 
Build: epf-composer-1.0-RC2-N20060919-1705-win32

Steps:
1. Open a clean library OpenUp 
2. Open a cp, e.g. test
3. Open its ADD, a dirty flag is raised in diagram editor, save it
4. Reset diagram layout in context menu, a dirty flag is raised, do not save.

Result: In context menu, you can undo change bounds for many times and then diagram will be massed up
when the dirty flag is still there, can not save or save all
Comment 1 Shashidhar Kannoori CLA 2006-09-20 14:31:42 EDT 
Fixed.
Comment 2 Wilma Wang CLA 2006-09-25 11:25:22 EDT 
not fixed, verified on RC2-N20060924-1445
after reset diagram layout and do not save, still can undo change bounds for many times and mass up the ADD
from user's perspective: I just reset the diagram layout, did not change bounds of any node, why can I undo change bounds?
from developer's perspective: reset diagram layout should be a compound command in CommandStack, rather than many single change bounds command.
It might be risky to refactor code at this time, but it is a problem and will cause confusion.
Comment 3 Bingxue Xu CLA 2006-09-25 14:05:08 EDT 
This is be investigated further in a future release.