Bug 157849 - [Edit] Compare with Each Other should use file buffers
Summary: [Edit] Compare with Each Other should use file buffers
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 181178 (view as bug list)
Depends on: 193324
Blocks:
  Show dependency tree
 
Reported: 2006-09-19 11:46 EDT by Michael Valenta CLA
Modified: 2021-12-09 15:30 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2006-09-19 11:46:05 EDT 
The equals in the ResourceNode is flawed in the sense that it uses the resource name for equality. Unfortunately, there are parts of Compare with Each ther that rely on this (see bug 157654). We should fix the equals and the Compare with Each Other action.
Comment 1 Bogdan Gheorghe CLA 2006-09-19 16:41:08 EDT 
Verified in HEAD
Comment 2 Dani Megert CLA 2006-09-20 04:10:25 EDT 
Is this now for M2 or M3 as advertised in bug 157654 comment 7?
Comment 3 Michael Valenta CLA 2006-09-20 05:51:49 EDT 
I think Bogdan closed this thinking it was bug 157654 was was fixed for M2. However, the proper fix has not been done (i.e. ResourceNode now has a flawed equals method and Compare with Each Other depends on this).
Comment 4 Michael Valenta CLA 2006-10-20 11:22:55 EDT 
After some reflection, I've decided not to change the existing class because it is possible that existing clients rely on the flawed behavior. I've changed the title to indicate that we shoudl investigate whether file buffers should be used with Comapre with Each Other. However, we do not plan on addressing this in 3.3.
Comment 5 Michael Valenta CLA 2007-06-22 08:53:12 EDT 
We are reworking Compare with Each Other in 3.4 at which point, we should be able to move back onto File Buffers.
Comment 6 Michael Valenta CLA 2007-06-28 16:40:20 EDT 
*** Bug 181178 has been marked as a duplicate of this bug. ***
Comment 7 Szymon Brandys CLA 2008-05-09 04:23:40 EDT 
Mass update - removing 3.4 target. This was one of the bugs marked for
investigation (and potential fixing) in 3.4 but we ran out of time. Please ping
on the bug if fixing it would be really important for 3.4, and does not require
API changes or feature work.
Comment 8 Eclipse Webmaster CLA 2019-09-06 16:14:56 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 9 Eclipse Genie CLA 2021-12-09 15:30:03 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.