Bug 157506 - [CommonNavigator] Can't Drop an External File into Project Explorer (Mac and Linux)
Summary: [CommonNavigator] Can't Drop an External File into Project Explorer (Mac and ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux-GTK
: P2 major (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Michael D. Elder CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords: contributed
: 231638 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-15 13:47 EDT by John Lanuti CLA
Modified: 2008-05-16 14:02 EDT (History)
6 users (show)

See Also:
eclipse: review+
bokowski: review+

Attachments
Ken Ryell's patch to fix this on both Linux and Mac (1.85 KB, patch)
2008-05-13 17:35 EDT, Francis Upton IV CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Lanuti CLA 2006-09-15 13:47:53 EDT 
Opened for IBM:

This is a linux only issue that happens both in RedHat and SLES. Windows is fine.
Problem:
User can't drag and drop files into the Project Explorer view
Expected results:
User should be able to drag and drop files into the Project Explorer view

Steps:
Go to the j2ee perspective (or open the PE view)
Create a new general project (note that this issue will happen with any project)
Open the Linux  File Browser and attempt to drag and drop any file (I'm using a simple text file) from your system into the newly created project in the workbench
Result:
The file is not added to the project.
Doing the same in the Navigator view or Package Explorer view works fine.
Comment 1 John Lanuti CLA 2006-09-18 14:52:15 EDT 
The J2EE tools do not provide any J2EE extensions for these types and actions on a general project.  The default JavaDropAdapterAssistant is being used and it returns a cancel status on red hat.
Comment 2 Mike Wilson CLA 2008-04-12 15:02:29 EDT 
Eric, this sounded like something you were looking at at one point...
Comment 3 Francis Upton IV CLA 2008-05-06 10:44:48 EDT 
Verified this is still not working in 3.4M6
Comment 4 Boris Bokowski CLA 2008-05-13 13:44:06 EDT 
*** Bug 231638 has been marked as a duplicate of this bug. ***
Comment 5 Francis Upton IV CLA 2008-05-13 17:35:41 EDT 
Created attachment 100063 [details]
Ken Ryell's patch to fix this on both Linux and Mac

This is an updated version of the patch he provided for bug 231638.

Boris, I think this is low risk and high value and we should get this in for RC1 if possible.  I have tested this on Linux and Ken has on the Mac.
Comment 6 Francis Upton IV CLA 2008-05-14 01:59:12 EDT 
Boris, just another ping to make sure this one gets reviewed and in for RC1, it's pretty important.
Comment 7 Francis Upton IV CLA 2008-05-14 16:50:55 EDT 
Boris, another ping on this to try to get it in for RC1.
Comment 8 Francis Upton IV CLA 2008-05-14 16:58:08 EDT 
Eric, can you also have a look at this since it's drag/drop related?
Comment 9 Boris Bokowski CLA 2008-05-14 21:31:00 EDT 
Francis, on which platforms have you tested this?
Comment 10 Francis Upton IV CLA 2008-05-14 21:55:54 EDT 
(In reply to comment #9)
> Francis, on which platforms have you tested this?
> 

I personally tested Linux and Ken tested it on the Mac.  I can test on Windows if you like.
Comment 11 Kim Horne CLA 2008-05-15 09:33:49 EDT 
Seems sensible.
Comment 12 Boris Bokowski CLA 2008-05-15 09:48:39 EDT 
Fix released to HEAD.
Comment 13 Francis Upton IV CLA 2008-05-15 09:58:51 EDT 
Ken, thanks for your contribution to this and your persistence in pushing to get it resolved.  Can you please verify this is working when you get the build that includes this, which should be tonight's Ibuild.
Comment 14 Ken Ryall CLA 2008-05-16 14:02:46 EDT 
I have verified that this works correctly now with the I20080515-2000 build.