Community
Participate
Working Groups
N20060911-0010. The commit dialog now marks spelling errors [great]. Now I should also be able to add a word to the dictionary and/or fix the error using words from the dictionary.
I knew this was coming;-) I agree that this would be helpful but we don't have the manpower to provide this feature. Patches are greatfully accepted.
It would be easy to implement, but I'll hold on that till Daniel figure out how he want to deal with bug 88293 ;-)
Mmh, I don't think this bug depends on bug 88923 and I'm not corrupt ;-)
It depends. ;-)
I'll provide a patch for that one.
Created attachment 72467 [details] Fix NOTE: This fix depends on HEAD of org.eclipse.ui.ide
(In reply to comment #6) > NOTE: This fix depends on HEAD of org.eclipse.ui.ide Daniel, can you give some clue how this could be implemented without new support in head? Not all plugins can afford to pickup trunk version of ide.
>Not all plugins can afford to pickup trunk version of ide. Not sure what you mean here. No, there is not other way than using HEAD of ui.ide as the quick assist binding needed to be extended to dialogs.
You will not get compile errors if you apply the patch. It just won't work until you have the update binding from ui.ide's plugin.xml.
(In reply to comment #8) > >Not all plugins can afford to pickup trunk version of ide. > Not sure what you mean here. There is number of 3rd party plugins or projects outside Platform/IDE that would benefit from this feature and those projects are going to be used with Eclipse 3.3 release for at least another year. So, it would be handy if they could use some workaround to get this functionality in 3.3. > No, there is not other way than using HEAD of ui.ide as the quick assist > binding needed to be extended to dialogs. Can 3rd party plugins somehow enable own bindings to make it work on Eclipse 3.3?
You mean they go the painful way of downloading the SDK 3.4 and then only take CVS UI 3.4 but not IDE 3.4?
(In reply to comment #11) > You mean they go the painful way of downloading the SDK 3.4 and then only take > CVS UI 3.4 but not IDE 3.4? I mean that CVS UI plugin is not the only plugin that needs this feature and unlike CVS UI, other plugins won't have luxury to run on SDK 3.4 for another year. Henve, can they use some workaround to get this feature on 3.3?
The only thing that's outside CVS UI is the change of the binding in ui.ide. We could put that into 3.3_maintenance if Platform UI also agrees (I own the quick assist/fix command in there but the final shot is with them). Adding this to 3.3.0 is completely out of scope and not worth further discussion.
(In reply to comment #13) > The only thing that's outside CVS UI is the change of the binding in ui.ide. We > could put that into 3.3_maintenance if Platform UI also agrees (I own the quick > assist/fix command in there but the final shot is with them). So, would it work if 3rd party plugin would add this binding in its own plugin.xml or there is something else need to be done other then using adding init code like in your patch? <key commandId="org.eclipse.jdt.ui.edit.text.java.correction.assist.proposals" sequence="M1+1" schemeId="org.eclipse.ui.defaultAcceleratorConfiguration" contextId="org.eclipse.ui.contexts.dialogAndWindow" /> > Adding this to 3.3.0 is completely out of scope and not worth further > discussion. I never suggested that.
>I never suggested that. k. Saw 3.3 in your comment and wasn't sure. Sorry if I misunderstood. Yes, that works as well. You can even use the more concrete dialog context: contextId="org.eclipse.ui.contexts.dialog"
This would be the corrrect and better way as this also works for those based off 3.3.0.
Great! Thanks Daniel
BTW: The viewer is not updated until the next text change. This is not a bug with the patch itself but a missing feature in Platform Text: so far this only works in editors. I've now fixed that in HEAD (see bug 194574 for details).
Patch released to HEAD. Thanks Dani.
By the way, shouldn't be quicfix action checking if operation can be done before calling it? I.e. something like this: Action quickFixAction = new Action() { public void run() { if(viewer.canDoOperation(ISourceViewer.QUICK_ASSIST)) { viewer.doOperation(ISourceViewer.QUICK_ASSIST); } } }; I am not completely sure how source viewer is configured, but there is probably some possibility that dictionary is not installed or spellchecking is disabled...
The TSVC already does that check.
Verified in I20070808-1800. Add/ignore/fix with dictionary work smoothly.
*** Bug 210370 has been marked as a duplicate of this bug. ***
