Bug 156677 - To not show in the list the internal targets
Summary: To not show in the list the internal targets
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Platform-Ant-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-09-08 05:55 EDT by Nikolay Malyshev CLA
Modified: 2009-10-21 11:32 EDT (History)
5 users (show)

See Also:

Attachments
Patch after which 'hide internal targets' action hides also targets starting with '-' (6.43 KB, patch)
2008-05-18 12:02 EDT, Martin Karpisek CLA 		no flags Details | Diff
re-created patch (6.43 KB, patch)
2009-10-21 11:30 EDT, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolay Malyshev CLA 2006-09-08 05:55:31 EDT 
Ant's documentation:

Targets beginning with a hyphen such as "-restart" are valid, and
can be used to name targets that should not be called directly from
the command line.
Comment 1 Darin Swanson CLA 2006-09-08 10:25:13 EDT 
Thank you for the bug report.

There is filtering is for hiding internal targets. Internal targets
are defined by Apache Ant as those that do not have descriptions. 
See the action in the toolbar of the Ant editor outline.

We could expand this to include targets that have a name starting with a hyphen.
Comment 2 Martin Karpisek CLA 2008-05-18 12:02:39 EDT 
Created attachment 100816 [details]
Patch after which 'hide internal targets' action hides also targets starting with '-'

simple patch which implements enhancement as is in comment 1
- affects both outline and ant view
- test included
Comment 3 Gábor Lipták CLA 2009-10-21 10:30:48 EDT 
When will this modification be published? I mean when will the official download of eclipse bundle contain this modification?
Comment 4 Gábor Lipták CLA 2009-10-21 10:31:35 EDT 
I asked, since 3.5 do not contain this modification. I decompiled the class mentioned in the patch.
Comment 5 Darin Wright CLA 2009-10-21 10:46:26 EDT 
Resources on the Ant component are thin. Since a patch is provided, we can look at this in 3.6.
Comment 6 Michael Rennie CLA 2009-10-21 11:30:46 EDT 
Created attachment 150126 [details]
re-created patch

Re-created patch against current state of HEAD.
Comment 7 Michael Rennie CLA 2009-10-21 11:32:32 EDT 
Patch works perfectly and the new tests all pass - applied to HEAD.

Thanks for the patch Martin.
Comment 8 Michael Rennie CLA 2009-10-21 11:32:49 EDT 
verified