Bug 15616 - Startup reconciliation is not correct
Summary: Startup reconciliation is not correct
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Christophe Elek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-09 10:07 EDT by Vlad Klicnik CLA
Modified: 2002-05-10 06:19 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Klicnik CLA 2002-05-09 10:07:19 EDT
Using scenario from 15592 (brand new 20020508 plus org.eclipse.sdk_1.9.0.001)

* must specify -update to enable startup reconciliation
* start with new install (no workspace)
* startup/ shutdown (see first trace snip)
* add 001 version of feature (see next trace snip)
* startup

The reconciler is called with pessimistic.
Problem1: It reports there were no changes ... but 001 was new
Problem2: when workbench starts up and you go to update manager, it shown 001 as 
configured (ie: was picked up optimistically)


Initial startup:
================

org.eclipse.update.core_1.9.0^68166dac org.eclipse.update.internal.core.UpdateMa
nagerReconciler: begin
org.eclipse.update.core_1.9.0^68166dac org.eclipse.update.internal.core.UpdateMa
nagerReconciler: mode: optimistic
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ located  10 feature(s)
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ feature stamp: -4026991
20 [no changes] in 10ms
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ located  53 plugin(s)
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ plugin stamp: -10207946
13062 [no changes] in 30ms
org.eclipse.update.core_1.9.0^68166dac org.eclipse.update.internal.core.UpdateMa
nagerReconciler: no changes detected
org.eclipse.update.core_1.9.0^68166dac org.eclipse.update.internal.core.UpdateMa
nagerReconciler: end [1372ms]

Next Startup (after org.eclipse.sdk_1.9.0.001 added)
====================================================

org.eclipse.update.core_1.9.0^68167184 
org.eclipse.update.internal.core.UpdateManagerReconciler: begin
org.eclipse.update.core_1.9.0^68167184 
org.eclipse.update.internal.core.UpdateManagerReconciler: mode: pessimistic
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ located  11 feature(s)
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ feature stamp: 
-1021259866692 [no changes] in 10ms
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ located  53 plugin(s)
PlatformConfig: file:/D:/eclipse builds/eclipse20020508/ plugin stamp: 
1105615790 [was -1020794613062] in 30ms
org.eclipse.update.core_1.9.0^68167184 
org.eclipse.update.internal.core.UpdateManagerReconciler: no changes detected
org.eclipse.update.core_1.9.0^68167184 
org.eclipse.update.internal.core.UpdateManagerReconciler: end [3695ms]
Comment 1 Christophe Elek CLA 2002-05-09 15:23:24 EDT
Same problem comparing two file URL
Fixed in reconcile where the compare between a configured site URL and the URL
of the found site to see if they are the same is done in
SiteReconciler.sameURL(URL,URL);

Verified
1) the change is reported
2) the new feature is disable

(if the version and id in the new feature.xml is the same as a configured
feature, the feature appear twice a configured)
Comment 2 Christophe Elek CLA 2002-05-10 06:19:03 EDT
Re-checked, will release in todays build