Bug 155781 - [Project Sets] Exported Team Project Sets (.psf) should be sorted
Summary: [Project Sets] Exported Team Project Sets (.psf) should be sorted
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2006-08-31 05:13 EDT by Martin Oberhuber CLA
Modified: 2007-06-06 13:32 EDT (History)
1 user (show)

See Also:


Attachments
patch for org.eclipse.team.ui (1.71 KB, patch)
2007-03-15 11:06 EDT, DJ Houghton CLA
no flags Details | Diff
team.ui jar (1.15 MB, application/octet-stream)
2007-03-15 11:12 EDT, DJ Houghton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2006-08-31 05:13:29 EDT
Export > Team Project Set creates a *.psf file. The <project reference="..."/> lines inside the <provider> tag should be sorted on a per-line basis.

Rationale: In an ongoing project, it is common that plugins are added to the psf file over time, and the psf file itself is checked in under version control.

Because the current .psf files are not sorted, every time a plugin is added and the psf file is re-exported, it is hard to verify that the set is still correct: minor modifications change the entire psf file, therefore merging and updating the files is cumbersome. In fact, I have fallen back to sorting the files manually in Emacs before I check them in. This should be done by the export tool already.
Comment 1 Michael Valenta CLA 2006-09-06 13:12:21 EDT
Makes sense. However, we don;t have the manpower to address this in 3.3. Patches will be accepted.
Comment 2 DJ Houghton CLA 2007-03-15 11:06:12 EDT
Created attachment 60953 [details]
patch for org.eclipse.team.ui

Here is a patch which fixes this problem. Rather than using a List to hold the workspace projects, it uses a SortedSet with the comparator set to sort by the lower-case version of the project name.
Comment 3 DJ Houghton CLA 2007-03-15 11:12:12 EDT
Created attachment 60954 [details]
team.ui jar

Martin, here is a new team.ui bundle that you can use which contains the patch. I am using this with Eclipse SDK build i0313.
Comment 4 Michael Valenta CLA 2007-03-15 16:40:23 EDT
Patch released to HEAD. Thanks
Comment 5 Martin Oberhuber CLA 2007-03-16 09:13:48 EDT
Thanks! This will relieve me from post-processing in Emacs.
Comment 6 Michael Valenta CLA 2007-03-20 10:30:16 EDT
verified