Bug 155212 - Misprints in SWT Win32 code ?
Summary: Misprints in SWT Win32 code ?
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Steve Northover CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-08-25 08:30 EDT by Oleg Krasilnikov CLA
Modified: 2007-06-05 16:12 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Krasilnikov CLA 2006-08-25 08:30:51 EDT 
While porting SWT to Win64 [Bug #57151],
the following 2 strange places were found:

1. Strange usage of hImage handler (may be 
   super.setBackgroundImage should be called ?) 
org.eclipse.swt.widgets/Scale.java:285
   void setBackgroundImage (int hImage) {
	super.setBackgroundPixel (hImage);

2. "sizeof" is used for (maybe) wrong object 
   (NMLVCUSTOMDRAW instead of NMTVCUSTOMDRAW)
org.eclipse.swt.widgets/Tree.java:1075
   OS.MoveMemory (lParam, nmcd, NMLVCUSTOMDRAW.sizeof);

Are these places real bugs or... ?
Comment 1 Steve Northover CLA 2006-08-28 21:46:49 EDT 
Real bugs.
Comment 2 Steve Northover CLA 2006-08-28 21:51:55 EDT 
Fixed > 20060828
Comment 3 Steve Northover CLA 2006-08-28 21:53:21 EDT 
Fixed > 20060828