Bug 154907 - Ant - Sort variables in the Variables view
Summary: Ant - Sort variables in the Variables view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 123658 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-23 14:36 EDT by Simon Archer CLA
Modified: 2008-05-12 13:18 EDT (History)
6 users (show)

See Also:
Darin_Swanson: review+
darin.eclipse: review+


Attachments
patch to org.eclipse.ant.ui (2.54 KB, patch)
2007-06-11 01:36 EDT, Brock Janiczak CLA
no flags Details | Diff
Brock's patch with copyright and credit (5.97 KB, patch)
2008-05-12 00:04 EDT, Darin Swanson CLA
Darin_Swanson: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2006-08-23 14:36:59 EDT
When debugging an Ant script the variables shown in the Variables view are not sorted.

I see 3 categories: System Properties, User Properties and Runtime Properties, all of which contain unsorted variables.  Please alphabetically sort the variables within the categories.

It might be nice to optionally remove the categories and have all varialbles alphabetically sorted.

The best workaround for finding a variable is the rather useful "Find..." context menu, which I only found while investigating enhacement request.
Comment 1 Brock Janiczak CLA 2007-06-11 01:36:41 EDT
Created attachment 70803 [details]
patch to org.eclipse.ant.ui

This patch makes properties comparable and also sorts the properties in AntPropertiesValue#getVariables before returning them.

It would probably make more sense to add a sorter to the view instead of doing it in the model, but i couldn't figure out how to do it.
Comment 2 Darin Wright CLA 2007-06-11 09:46:43 EDT
The variables view is virtual and does not support sorting.
Comment 3 DJ Houghton CLA 2008-04-01 09:21:20 EDT
Word on the street is that the contents can't be sorted in the view but it can be done by the content provider. This would be a really cool fix for the 3.4 polish work.
Comment 4 Darin Swanson CLA 2008-05-01 13:13:56 EDT
*** Bug 123658 has been marked as a duplicate of this bug. ***
Comment 5 Darin Swanson CLA 2008-05-12 00:04:24 EDT
Created attachment 99646 [details]
Brock's patch with copyright and credit
Comment 6 Darin Swanson CLA 2008-05-12 00:08:30 EDT
Please review Darin W
Comment 7 Darin Wright CLA 2008-05-12 13:17:56 EDT
Reviewed/applied patch.
Comment 8 Darin Wright CLA 2008-05-12 13:18:09 EDT
Fixed.
Comment 9 Darin Wright CLA 2008-05-12 13:18:25 EDT
Verified.