Bug 154782 - [Undo] [IDE] - Marker operations become invalid if the marker is deleted and then restored
Summary: [Undo] [IDE] - Marker operations become invalid if the marker is deleted and ...
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2006-08-22 19:36 EDT by Susan McCourt CLA
Modified: 2009-08-30 02:09 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2006-08-22 19:36:40 EDT
Consider this sequence of operations
- Create a task
- Modify the task's attributes (via properties dialog or cell editor in tasks view)
- Delete the task

You may now "Undo Delete Task"

This correctly recreates the marker with all the attributes it had prior to deletion.

Problem/Feature
In theory, you should then be able to undo the prior modification of the marker's resources.  The current implementation does not support this, since the marker was deleted and recreated.  The new marker has a different id.  The original update operation knows the original marker and doesn't attempt to establish any relationship based on equality (ie, same location, resource, and attributes).  Doing so would be somewhat dangerous since we don't know that all "equal-looking" markers really refer to the original marker.

There are other similar scenarios, but the basic issue is that if a marker is deleted (by a delete, or an undo of a create, etc.) then any other operations that refer to that marker will now be invalid.
Comment 1 Susan McCourt CLA 2006-08-22 19:38:00 EDT
This may not be a priority for 3.3, but marking 3.3 for now so that all limitations of the new workspace undo support can be examined and documented.  I think we can look at this bug again after we implement undo for resource create/update/delete, because we will have similar issues for resources, not just markers.
Comment 2 Susan McCourt CLA 2006-11-09 14:19:09 EST
I doubt this is a big deal for 3.3.

It didn't turn out to be an issue with resources, since you can always get and keep a handle for a non-existent resource, and it will "work" once the resource does exist.  So the handles kept by undoable resource operations tend to work across resource delete/recreates.

But marker id's don't work this way, so the marker ops tend to get stale faster.  
Comment 3 Susan McCourt CLA 2007-02-13 17:40:54 EST
I don't see this as a 3.3 issue.  Marking REMIND for now.
Comment 4 Denis Roy CLA 2009-08-30 02:09:32 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.