Bug 154467 - [WorkingSets] (Patch attached) Smart selection of single WorkingSets
Summary: [WorkingSets] (Patch attached) Smart selection of single WorkingSets
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 154465
Blocks:
  Show dependency tree
 
Reported: 2006-08-20 08:54 EDT by Benjamin Muskalla CLA
Modified: 2006-09-05 14:30 EDT (History)
1 user (show)

See Also:


Attachments
workingset_dialog_dblclick.diff (1.11 KB, patch)
2006-08-20 08:58 EDT, Benjamin Muskalla CLA
no flags Details | Diff
new_workingset_dialog_dblclick.diff (1.24 KB, patch)
2006-08-21 15:27 EDT, Benjamin Muskalla CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2006-08-20 08:54:39 EDT
If you open the "Select Working Set" dialog, you can check an item in the list and press ok to activate this Working set. If you do a double click in the list, nothing happens (not nothing, but nothing visible for the user). The dialog is closed and nobody knows whats going on.

Here is a patch to extend the dialog by selecting the working set you double.clicked on.
Comment 1 Benjamin Muskalla CLA 2006-08-20 08:58:45 EDT
Created attachment 48249 [details]
workingset_dialog_dblclick.diff

At the moment, this patch does nothing but...no, nothing :-)

The problem is that the dialog does not honor the selection in the list when the third option isn't checked.

The patch depends on bug 154465 to work correctly.
Comment 2 Benjamin Muskalla CLA 2006-08-21 15:27:30 EDT
Created attachment 48323 [details]
new_workingset_dialog_dblclick.diff

As Boris won't fix bug 154465, here is a new version of the patch which does not require events from the CheckBoxTableTree. It's (in my eyes) not an very elegant solution in this case, but i can't change the position of the JFace devs (it's ok - but i don't understand it. But dont't worry - i like you all ;) )
Comment 3 Kim Horne CLA 2006-09-05 08:53:15 EDT
Slightly modified patch applied - setCheckedElements used instead of setAllChecked/setChecked
Comment 4 Kim Horne CLA 2006-09-05 14:28:55 EDT
Reopening to reassign
Comment 5 Kim Horne CLA 2006-09-05 14:30:29 EDT
Marking as fixed.