Bug 153574 - Track changes from applying a patch
Summary: Track changes from applying a patch
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.6   Edit
Hardware: PC Windows XP
: P4 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 179600 198898 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-11 10:28 EDT by Daniel Berg CLA
Modified: 2007-08-23 01:56 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Berg CLA 2006-08-11 10:28:32 EDT
When I activate a task and then apply a team patch I do not see the changed contents when I appy mylar settings.  I need to physically open the files in an editor before mylar starts to track the content changes.
Comment 1 Mik Kersten CLA 2006-08-24 18:07:30 EDT
The problem is that Mylar considers all files not modified by you to be indirectly interesting, whereas files that you select and edit are directly interesting.  Directly interesting elements show in filtered views like the Package Explorer, whereas indirectly interesting things are only used for operations such as change set management (so these files do get put into the active change set).

On the Mylar project we work around this by asking that a context be attached with each patch that's submitted.  But that's not realistic for all projects.  So we should add support for this, although this will require some work because interaction monitoring is currently stateless (i.e. when resources change we don't know if it is as a result of a patch being applied or a refactoring completion).  

An easy alternative is to provie a "Mark interesting" action in the Synchronize view that would allow you to click a Change Set node or anything below it, and would have the effect of making everything contained within that node interesting (i.e. show up in the Pacakge Exploer).  Thoughts?
Comment 2 Eugene Kuleshov CLA 2006-08-24 23:58:15 EDT
By the way, can't we just parse patches attached to issue and reconstruct context based on the content of the patch?...
Comment 3 Mik Kersten CLA 2006-08-28 13:31:21 EDT
If you mean to get the Java element contents, yes, I think that's a better approach overall.  but would be more work since the Apply Patch wizard is very closed (package private classes).  Also, it would be a language-specific solution, an we would still want a generic solution.

So maybe the right approach for now is to parse the patch for all changed files instead of relying on resource modifications.  I'm not sure if we'll have a reasonable way to know when the Apply Patch wizard has finished, but could look into that.
Comment 4 Eugene Kuleshov CLA 2006-08-28 14:25:35 EDT
(In reply to comment #3)
> So maybe the right approach for now is to parse the patch for all changed files
> instead of relying on resource modifications. 

That is what I meant. This should be quite portable because of the unified diff format.

BTW, I've been trying to pull attached conttexts several times and found their quality quite bad. E.g. you can try to get context of that spellchecking issue that Rob completed... I believe  got more context just looking at the patch.
Comment 5 Mik Kersten CLA 2006-09-11 18:58:45 EDT
By the context quality, do you mean that you'll see a bunch of folders without files in them?  That's what I've noticed in a few cases, and will be resolved with bug 118542 and related context model improvements that are scheduled for 0.7/1.0.
Comment 6 Eugene Kuleshov CLA 2006-09-11 21:29:23 EDT
(In reply to comment #5)
> By the context quality, do you mean that you'll see a bunch of folders without
> files in them?  That's what I've noticed in a few cases, and will be resolved
> with bug 118542 and related context model improvements that are scheduled for
> 0.7/1.0.

I guess not only that, but also context had none or just one relevant resource unfiltered in package explorer after I activated it.

Comment 7 Mik Kersten CLA 2006-11-20 20:14:51 EST
Current work-around is to attach context with the patches.  In the event that is not possible, the manual work-around is to select Open via the Synchronize view's context menu in order to manually populate the task context.
Comment 8 Mik Kersten CLA 2007-03-28 22:14:47 EDT
*** Bug 179600 has been marked as a duplicate of this bug. ***
Comment 9 Mik Kersten CLA 2007-03-29 00:29:30 EDT
Done.  See comment on bug 179599.
Comment 10 Mik Kersten CLA 2007-08-23 01:56:34 EDT
Added documentation on this to the User Guide: http://wiki.eclipse.org/Mylyn_User_Guide#Working_with_patches
Comment 11 Mik Kersten CLA 2007-08-23 01:56:50 EDT
*** Bug 198898 has been marked as a duplicate of this bug. ***