Bug 153156 - [CommonNavigator] Project Explorer filters dialog needs UI polishing
Summary: [CommonNavigator] Project Explorer filters dialog needs UI polishing
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Michael D. Elder CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, usability
: 158275 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-08 15:04 EDT by Markus Keller CLA
Modified: 2007-04-26 13:10 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-08-08 15:04:30 EDT
I20060807-2000

Project Explorer view menu > Filters...:
- dialog title must be title case
- dialog title should match action name:
  - either call dialog "Project Explorer Filters" or
  - call action "Preferences..." and dialog accordingly (like Synchronize view)
- tabs: "Available" is unnecessary, "Filters" and "Content" is enough
- message is below tree on both pages, should be above
    (e.g. "Select the filters to apply [..]:")
- initial focus should be in filter field, not tab
Comment 1 Markus Keller CLA 2006-09-25 06:10:46 EDT
*** Bug 158275 has been marked as a duplicate of this bug. ***
Comment 2 Martin Aeschlimann CLA 2006-09-25 06:15:34 EDT
From bug 158275:

The second tab seems unrelated to filters. I would move it to a separate
action (not 'Filters...', but maybe 'Configure...'). This would avoid the tabs
and avoid the border in border layout which doesn't look good. 
Comment 3 Markus Keller CLA 2006-09-25 06:41:58 EDT
Also from bug 158275:
The dialog has resize problems. Making the dialog larger flickers in WinXP.
Comment 4 Anton Leherbauer CLA 2006-09-26 05:47:07 EDT
I would also suggest to group the filter items by their contributing content extension or by some new filter category to avoid clutter when more and more extensions contribute their filters.

Filters from disabled content extensions should not be shown in the list at all.
Comment 5 Markus Keller CLA 2007-02-28 13:37:42 EST
This should be fixed for 3.3.
Comment 6 Michael D. Elder CLA 2007-04-26 13:09:34 EDT
Updated the strings according to advice and moved the creation of the instruction label to the top of the tab. 

The action is still under one menu ("Customize View...") which had the "Filters" and "Content" tab. The ultimate goal is to make it possible for extensions to contribute their own tabs in the future. Each tab is fairly contained; and in the future, an extnsion might contribute 0..* of these tabs for their own custom preferences/settings. 

Not all filters are associated with an extension, so the filters are not "filtered" based on their associated extensions at this time. Similarly, grouping filters with their "contributing" extensions has proven hazardous in the past (an earlier version of the framework did this). Some filters also apply to other content, even if their contributing extension is disabled. 

Please open a separate enhancement request if you feel this is an important requirement. 

Fixed and released for > I20070426_0300.