Bug 151861 - [History View] History view does not link to selection in Synchronize view
Summary: [History View] History view does not link to selection in Synchronize view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 154024 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-07-26 11:15 EDT by Markus Keller CLA
Modified: 2007-06-06 13:30 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2006-12-08 05:29 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-07-26 11:15:52 EDT 
I20060725-0800

- arrange Synchronize and History views such that they can both be seen at the same time
- enable 'Link with Editor and Selection' in History view
- select a changed file in Synchronize view

Expected: History view should show history for selected file
Was: no reaction
Comment 1 Bogdan Gheorghe CLA 2006-07-27 14:33:14 EDT 
I20060725-0800

This seems to work for me:

i) I have a bunch of team related projects that have incoming changes. I made a bunch of changes to a different project in my workspace (to ensure I have both incoming and outgoing changes).

ii) I switched over to the Team Sync perspective, which has the History View visible as a default.

iii) Performed a sync and got some incoming and outgoing changes. Turned on linking in the History View, clicked on both incoming and outgoing changes => watched History View update as expected. I also tried cycling through all of the models modes (All Models, Java and Workspace) and through the various filtering modes (incoming, outgoing, conflicts).

iv) Finally I tried opening the Sync View and History View while in the Java perspective. Followed step iii again and watched the History View update.

Am I missing anything here that you did? Did you click on a new file? Did you have multiple instances of the History View open? Was the view pinned?
Comment 2 Markus Keller CLA 2006-07-28 04:43:05 EDT 
I tried to reproduce in a fresh workspace, and I think I found the deciding factor: I'm still using a pinned old (not model-based) synchronization. To reproduce, you have to switch off 'Preferences > Team > CVS > Synchronize/Compare > Allow models (e.g. Java) to participate in synchronizations' and then create a new synchronization.
Comment 3 Bogdan Gheorghe CLA 2006-07-31 16:50:33 EDT 
That did it! I'll take a look...
Comment 4 Michael Valenta CLA 2006-08-17 14:56:05 EDT 
*** Bug 154024 has been marked as a duplicate of this bug. ***
Comment 5 Michael Valenta CLA 2006-12-07 09:24:11 EST 
This applies only to the non-model based Synchronize pages. As such, we do not plan on addressing it. Patches will be accepted.
Comment 6 Markus Keller CLA 2006-12-08 05:29:28 EST 
Created attachment 55299 [details]
Patch

This is a minimal patch. If you think SyncInfoModelElement should adapt to IResource in general, please move it to SyncInfoModelElement#getAdapter(..).
Comment 7 Michael Valenta CLA 2006-12-08 09:00:54 EST 
We don't want SyncInfoModelElement to adapt to IResource so the patch you have provided is the way to go. I will put it in today.
Comment 8 Michael Valenta CLA 2006-12-08 09:05:43 EST 
Fix released to HEAD. Thanks.
Comment 9 Michael Valenta CLA 2006-12-12 09:34:23 EST 
Verified