Bug 150910 - [typing] When editing file in multiple editors each editor should have separate undo buffer
Summary: [typing] When editing file in multiple editors each editor should have separa...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-18 05:11 EDT by Max Gilead CLA
Modified: 2019-09-06 16:04 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Gilead CLA 2006-07-18 05:11:34 EDT
When editing file in multiple editors each editor should have separate undo buffer. Right now they share undo buffer which makes editing file in multiple places (isn't it the point of multiple editors?) *very* painful.
Comment 1 Paul Webster CLA 2006-07-28 09:02:41 EDT
Since multiple editors are editing one underlying resource (and model), and the changes in each editor shows up in the other editor, it makes sense to me that they have one undo buffer.

Moving to text for comment.

PW
Comment 2 Tom Hofmann CLA 2006-07-28 09:15:14 EDT
Comment 1 sums it up - all editors operate on the same IDocument model and hence one undo history. Also, this would not work with the timestamp based undo model of the editor.

Susan, I believe you did most of the new editor undo support - Is the above correct, or would there be a way to have separate undo streams for each editor and only force a combined undo if the changes overlap?
Comment 3 Susan McCourt CLA 2006-07-28 12:47:11 EDT
In 3.1 and prior releases, the undo buffers were kept per editor rather than per document.  We received strong complaints that we should be able to share the undo history per document, and this feature was implemented in 3.2 with a document-based undo manager.  See bug #89599 (and its duplicates).  There was discussion in this bug of exposing an option to control the behavior, but given the many requests for a shared model (and confusion caused by separate ones), we did not implement the option.  It is still something that could be considered.
Comment 4 Max Gilead CLA 2006-07-29 18:45:28 EDT
At work I'm working on files with 10000 or more lines (don't ask...). They have several functional parts. Now, if I have opened three editors, A, B and C, and I work with editor A on line 100, editor B on line 5000 and editor C on line 10000. Now I change code in editors: A, B, C, B, C, A, B, A, C, A. Now while working in editor A I discovered I made a mistake when working in editor C and I'd like to undo all changes in it. There are two serious problems with current behavior:
1. It's simply impossible without undoing changes in editors A and B
2. Cursor jumps around the file to places unrelated to the task I was working on.
With complicated and huge files it's very easy to get confused what's going on and make stupid mistakes. With separate undo buffers I could treat editors A, B and C as completely separate editors, accidentally editing three parts of the same file and not three separate files.
Comment 5 Dani Megert CLA 2006-07-31 06:25:55 EDT
I see your point but there are currently no plans to provide the option that Tom mentioned in comment 2.
Comment 6 Dani Megert CLA 2007-06-22 09:59:30 EDT
Get rid of deprecated state.
Comment 7 Eclipse Webmaster CLA 2019-09-06 16:04:06 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.