Bug 150217 - Feature request: add BaseAgent.sendData(int, byte[]) in Java API
Summary: Feature request: add BaseAgent.sendData(int, byte[]) in Java API
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Igor Alelekov CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords: plan
Depends on:
Blocks:
 
Reported: 2006-07-11 03:06 EDT by Igor Alelekov CLA
Modified: 2016-05-05 10:44 EDT (History)
5 users (show)

See Also:


Attachments
Introduce JNI implementation of sendData(int, byte[]) and fix sendData(int, char[]) bug (2.89 KB, patch)
2007-05-08 09:42 EDT, Stanislav Polevic CLA
no flags Details | Diff
Introduce SendData(int, byte[]) Java implementation (4.83 KB, patch)
2007-05-08 09:45 EDT, Stanislav Polevic CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Alelekov CLA 2006-07-11 03:06:35 EDT
To be able to send binary data via DataChannel 
It is need additional Java API method BaseAgent.sendData(int, byte[])

Existing method BaseAgent.sendData(int, char[]) can't be used in binary data transfer since char is Unicode 2 bytes data type and can be used in strings transfer only.
Comment 1 Guru Nagarajan CLA 2006-11-04 19:58:53 EST
Deferring since cannot be contained in 4.3
Comment 2 jkubasta CLA 2007-04-03 14:40:11 EDT
Not yet triaged
Comment 3 Stanislav Polevic CLA 2007-05-08 09:42:13 EDT
Created attachment 66283 [details]
Introduce JNI implementation of sendData(int, byte[]) and fix sendData(int, char[]) bug

This is a patch for both Bug 150217 and Bug 150216.
Comment 4 Stanislav Polevic CLA 2007-05-08 09:45:17 EDT
Created attachment 66284 [details]
Introduce SendData(int, byte[]) Java implementation

This is a patch for both Bug 150217 and Bug 150216.
Comment 5 Stanislav Polevic CLA 2007-05-08 09:49:17 EDT
The patches are submitted.
Samson, could you review the patches, please?

Comment 6 Samson Wai CLA 2007-05-08 12:18:21 EDT
Hi Stanislav. Is there a reason of changing the IBaseAgent interface at this time? Is there a possiblity of breaking existing agent if we do so now?

BTW this is not targeted to 4.4 and is not in plan as an enhancement. I would not suggest checking this in now until this enhancement is approved since this might be an API-breaking change.
Comment 7 Marc Lafon CLA 2007-10-24 14:48:46 EDT
Hi all,
 
You have all my apologies if I interfere in your work processes, but I read the patches attached by Stanislav, and two facts are clear to me :

1. The correction of the bug #150216, included in the patch, does not affect the API.

2. The modification does not change the API, it just adds a new function without any modification to the existing ones.

So it would be great if the patch could be committed shortly, or a least if it could be broken in two. If so, the corrective part of the patch could be committed and the bug 150216 would be closed, at least.

Anyway, to develop an Java agent with this bug is not really clean.

Best regards.

Marc 
Comment 8 Igor Alelekov CLA 2007-12-07 08:05:22 EST
Resolving as fixed
Comment 9 Paul Slauenwhite CLA 2009-06-30 09:58:47 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.