Bug 150147 - [ViewMgmt] Tabbed view not restored when saving and restoring workbench
Summary: [ViewMgmt] Tabbed view not restored when saving and restoring workbench
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2006-07-10 10:51 EDT by Kevin O'Riordan CLA
Modified: 2007-09-10 05:21 EDT (History)
3 users (show)

See Also:


Attachments
This is the output of saveState(IMemento memento) (3.09 KB, text/xml)
2006-07-10 10:53 EDT, Kevin O'Riordan CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin O'Riordan CLA 2006-07-10 10:51:57 EDT
Sometimes, when creating and restoring the Eclipse workbench, a view that resided in a folder of views gets lost during the save/restore cycle.

I've checked the memento that is saved by creating an xml memento using IWorkbenchWindowConfigurer.saveState() and the view doesn't get listed in the list of views under the <info folder="..." part=".." ...> element. The view does show up under <perspective activePart="viewName"...> though.

To reproduce this, I created a simple perspective with just two views side by side, dragged the left view to the right of the second view in tabbed formation, closed the workbench and restored the workbench. (I also called saveState to get a memento for debugging).
Comment 1 Kevin O'Riordan CLA 2006-07-10 10:53:48 EDT
Created attachment 46008 [details]
This is the output of saveState(IMemento memento)

The name of the view that goes missing is com.ibm.notes.samples.custombuddylistcomponent.CustomBuddyListId:5_G0Q03FH208HD9026ICQ4AU00D6

It should appear in the same folder as com.ibm.workplace.noteswc.views.NotesViewData:5_G0Q03FH208HD9026ICQ4AU00D3
Comment 2 Boris Bokowski CLA 2006-07-10 13:58:40 EDT
Investigate for 3.2.1
Comment 3 Boris Bokowski CLA 2006-08-15 21:56:36 EDT
I think I need help from you with this (hoping that you have a reproducible case).  Could you please put a breakpoint at the beginning of PerspectiveHelper.collectViewPanes(List) and step through to see why your view is not added to the result?

Thanks.
Comment 4 Tod Creasey CLA 2006-08-16 13:07:52 EDT
Boris if you are not planning to address this for 3.2.1 you should remove the tag. The release candidates start next week.
Comment 5 Boris Bokowski CLA 2006-08-22 10:30:19 EDT
There is no time left to fix this for 3.2.1.  Since I haven't heard back yet, I have to move this to 3.3.
Comment 6 Boris Bokowski CLA 2007-04-27 23:27:09 EDT
Deferring.
Comment 7 Kevin O'Riordan CLA 2007-09-10 05:21:17 EDT
Turns out this was due to something I was doing wrong.