Community
Participate
Working Groups
As already discussed in bug 147816 comment #8, #9, #12, #13 and #18 naming of classes should be consistens across connectors.
Trac currently uses the following naming schema: Trac Connector - 1..n Task Repository -> Trac Client Manager - 1..n Trac Client (TracXmlRpcClient, Trac09Client)
When the renaming is done all *Trac09* classes should be renamed to *TracWeb* to avoid confusion with the access method and version of the repository.
We focused on fixing naming for the Tasks framework. Connectors are still largely in internal packages and naming will need to be fixed post 1.0.
Renamed Trac classes as per comment 2.
Created attachment 59622 [details] mylar/context/zip
Great. I'll try to go through the other connectors before 2.0M2 ships, so that we set a good example for connector implementors.
I am considering renaming of JiraServer to JiraClient for consistency with TracClient and BugzillaClient. Opinions?
(In reply to comment #7) > I am considering renaming of JiraServer to JiraClient for consistency with > TracClient and BugzillaClient. Opinions? I agree.
Yes, I think that's a good idea because it names the class for what it is (a client to the JIRA server) and not what it abstracts (the JIRA server). If the class were a data type it would be fine to name it for what it abstracts, but it's a connectivity mechanism. I also thing that JiraServerFacade is a good name. It sounds more complicated so I prefer JiraClient. Also, JiraClient parallels the naming that we inherit from HttpClient. Steffen: if you make this rename could you add a note to the Integrator Reference on this naming convention?
Alright. I did not understand your comment regarding JiraServerFacade though. That class is essentially a facade to JiraServerManager (which would be renamed to JiraClientManager).
(In reply to comment #10) > Alright. I did not understand your comment regarding JiraServerFacade though. > That class is essentially a facade to JiraServerManager (which would be renamed > to JiraClientManager). Yes, the rename to JiraClientManager sounds right. I was referring to the fact that "FooServerFacade" was an alternative naming convention to "FooClient", but I think that we've all settled on the latter.
Renaming done. Anything left to do here?
Created attachment 66390 [details] mylar/context/zip
This should do it.
Done.