Bug 149816 - [Manifest Editor] plugin.xml source editor syntax coloring confused by \
Summary: [Manifest Editor] plugin.xml source editor syntax coloring confused by \
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-07-06 08:47 EDT by Markus Keller CLA
Modified: 2008-04-12 08:06 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2008-03-10 18:43 EDT, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (660 bytes, application/octet-stream)
2008-03-10 18:43 EDT, Benjamin Cabé CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-07-06 08:47:51 EDT 
in jdt.ui's plugin.xml, there's a declaration
      <key
            sequence="M1+M2+\"
            contextId="org.eclipse.jdt.ui.javaEditorScope"
            commandId="org.eclipse.jdt.ui.edit.text.java.remove.block.comment"
            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"/>

Syntax coloring is broken after the "\": String literals are rendered as tags and vice versa.
Comment 1 Tarik Karaoglu CLA 2007-02-25 17:55:51 EST 
Beside this, when additional xml content is copy-pasted into the editor, editor coloring just turn plain black for this content. You have to change something (put a space and then delete this space) for each line to trigger that XML editor apply reasonable coloring into newly added content.
Comment 2 Benjamin Cabé CLA 2008-03-10 18:42:16 EDT 
"\" is considered as an escape character by the XMLScanner responsible for syntax highlighting. I'm not sure it makes senses in the XML world : if you want to say "\"" you'll use "&quot;"
Comment 3 Benjamin Cabé CLA 2008-03-10 18:43:37 EDT 
Created attachment 92098 [details]
Patch

Get rid of escape character
Comment 4 Benjamin Cabé CLA 2008-03-10 18:43:40 EDT 
Created attachment 92099 [details]
mylyn/context/zip
Comment 5 Benjamin Cabé CLA 2008-03-10 18:45:04 EDT 
(In reply to comment #1)
> Beside this, when additional xml content is copy-pasted into the editor, editor
> coloring just turn plain black for this content. You have to change something
> (put a space and then delete this space) for each line to trigger that XML
> editor apply reasonable coloring into newly added content.
> 

I already noticed that too. Could you please file a new bugzilla for this one ?
Comment 6 Chris Aniszczyk CLA 2008-03-10 20:35:31 EDT 
seems reasonable, let me ponder this one for a bit first.
Comment 7 Chris Aniszczyk CLA 2008-04-12 08:06:36 EDT 
Thanks again for the quality patch Benjamin!