Community
Participate
Working Groups
I20060628-1135 Javadocs of Saveable#doSave(..) and ISaveablePart#doSave(..) should specify the user interaction in case of failure. E.g. AbstractTextEditor currently shows a dialog if save failed. Other editors may not show a dialog and leave the user completely uninformed about the failure (see bug 147900, which turned out to be caused by a third-party editor that does not inform the user if the operation fails).
Saveable.doSave() specifies this: * @throws CoreException * if the save fails; it is the caller's responsibility to * report the failure to the user Is this what you are asking for? Unfortunately, ISaveablePart.doSave() is not spec'd to throw CoreException, so I guess we will have to specify it the other way around.
Oops, sorry about the wrong accusation -- Saveable#doSave(..) is indeed already well specified. However, DefaultSaveable#doSave(..) currently just calls ISaveablePart#doSave(..) and does not throw a CoreException, even if the save failed. Maybe it would be best to deprecate ISaveablePart#doSave(..) and ask clients to implement ISaveablesSource. This would also help implementing bug 149471.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the request is still relevant please remove the stalebug whiteboard tag.
