Community
Participate
Working Groups
The comment on PackageExplorerPart.createViewer is: * This viewer ensures that non-leaves in the hierarchical * layout are not removed by any filters. While this may make sense for many filters, it is preventing Mylar users from using the hierarchical layout because empty nodes end up being shown (see attachment). Could this rule be updated to "filter *empty* non-leaf" nodes instead, where determining "empty" alllows all the filters applied to the viewer to run? (Interestingly we have the same rule for Mylar's Task List.)
Created attachment 45356 [details] screenshot of filtering problem Mylar's interest filter determines that "internal" and the 5 nodes under it should be not be shown, but they are forced in.
I have to find out why this rule was introduced for the hierarchical mode.
I was wondering that too... perhaps if you have the following structure: one.two.Foo and end up with: one + two + Foo Then a filter that is intended to filter empty JarPackageFragment's will think that "one" is empty because it has no classes in it.
Any news on this? This blocks the single "known limitation" of Mylar, which is currently our longest standing and most-voted open bug (only 3 votes, but unlike enhancements we don't tend to keep bugs with votes alive very long). http://wiki.eclipse.org/index.php/Mylar_FAQ#Key_Limitations
fixed > 20060805 Tested that changing this isn't a performance problem. If we get some more experience with this I would also be ready to fix that in 3.2.1.
>Tested that changing this isn't a performance problem. Can you point me to the tests that prooves this? How many items and levels of nesting (i.e. package segments) were part of your tests?
I ran a profiler on a bigger project. Note that I also improve the hierarchical content provider performance for 3.2.
*** Bug 106678 has been marked as a duplicate of this bug. ***
Excellent--I just verified and this gets rid of the limitation in Mylar's interest filtering (comment#4) since the filtering is now consistent . Sorry for the slow reply, vacation time. And a pleasant surprise is that while I never used the Hierarchical presentation before Mylar because it forced too many clicks, I'm now finding it be the preferred mode since interest filtering and expansion removes the need for those clicks. Are you considering fixing this in 3.2.1?
I misspelled 'candidate', that's why I lost track of the bug. fix released in 3.2.1 > 20060828
verified in 3.2.1 M20060830-0800. Mik, can you verify as well?
Traveling now, will plan to do so mid next week.
This problem now appears for the Project Explorer when in hierarchical mode, with identical symptoms. Should I open a new bug or shall we use this one to discuss?
A new bug would be better as this one is verified fixed for 3.2.1
Done: bug 166872
I still have this issue in 3.5.2
>I still have this issue in 3.5.2 Please try again using the latest 3.6 candidate: http://download.eclipse.org/eclipse/downloads/drops/I20100608-0911/index.php and if you still see the problem, open a new bug report with steps to reproduce.
