Bug 147594 - JET Compiler doesn't create missing target folder
Summary: JET Compiler doesn't create missing target folder
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dave Steinberg CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-17 04:10 EDT by Eike Stepper CLA
Modified: 2008-05-13 17:09 EDT (History)
2 users (show)

See Also:

Attachments
patch (3.32 KB, patch)
2006-06-17 20:43 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
Reformatted version of Chris' patch (2.51 KB, patch)
2006-06-29 16:05 EDT, Dave Steinberg CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2006-06-17 04:10:18 EDT 
The JET Compiler is configured with the names/paths of two folders, one for the templates and one for the target classes (java source files). In EMF 2.1 we observed that the Compiler does not do its work if the target folder does not yet exist. Wouldn't it be simple to just let him create it in this case instead of reporting an error and stopping?
Comment 1 Chris Aniszczyk CLA 2006-06-17 20:43:01 EDT 
Created attachment 44765 [details]
patch

Hi EMF guys :) I figure I would have to show a little love.

This patch works on my end, let me know if you agree with the design decisions.
Comment 2 Chris Aniszczyk CLA 2006-06-17 20:44:53 EDT 
This little issue has bothered me for awhile too... hope it gets it soon ;)
Comment 3 Dave Steinberg CLA 2006-06-29 16:05:59 EDT 
Created attachment 45553 [details]
Reformatted version of Chris' patch

Thanks for showing some love.

Your patch looks good to me.  I'd be happy to apply it once our next cycle begins.  I've taken the liberty of formatting it to meet our conventions, and also used the existing IProgressMonitor in the IFolder.create() call.  I realize that the work counting is already all messed up in there and that this makes it no better, but I don't really think it's any worse, either.
Comment 4 Dave Steinberg CLA 2006-10-17 21:00:43 EDT 
The patch has (finally) been committed to CVS.

Thanks again.
Comment 5 Dave Steinberg CLA 2006-10-17 21:02:52 EDT 
[contrib email="zx@us.ibm.com"/]
Comment 6 Nick Boldt CLA 2006-11-03 17:40:19 EST 
Fixed in I200611021608.
Comment 7 Nick Boldt CLA 2008-01-28 16:47:29 EST 
Move to verified as per bug 206558.