Community
Participate
Working Groups
Link with Editor broken in Test Perspective. Using the TPTP-4.2.0-200606080100 build, selecting the Link with Editor button does not highlight the associated file in the Test Navigator when the file is open.
*** Bug 161326 has been marked as a duplicate of this bug. ***
Why is this defect targetted to future? If the Test team isn't planing to fix this, they should remove the button altogether. What is the reason for keeping this button if it has no purpose? I believe this is a serious usability issue and shouldn't be treated as a normal defect.
We need to change slightly the behavior of this button action in order to imitate the JDT 'link to editor' action. The bring to top event of an editor should select and reveal its element in the test navigator. FYI, at the moment the selection of an element in the test navigator brings to top the open editor of this element.
Jerome, please increase the priority to ensure it is completed for 4.4.
*** Bug 129228 has been marked as a duplicate of this bug. ***
*** Bug 153589 has been marked as a duplicate of this bug. ***
Has the priority for this defect been recently reviewed given its severity? If not, please take a few minutes and reevaluate the priority.
Test Navigator link with editor only works for BaseEditorPart. The implementation of Link With Editor should be more generic to work with any editor who's input can be adapted to an IFile. This is similar to the behavior of the Eclipse Resource Navigator. We have made use of the testNavigatorFileProxyFactory extension to add files of type .trcmxmi to the TestNavigator. This file has it's own custom editor associated with it. The editor is not of type BaseEditorPart. Hence, Link With Editor doesn't work in the Test Navigator. This would probably be common for users of the testNavigatorFileProxyFactory extension since these are untyped test assets which don't have associated Hyades editors. I also notice this issue for .html files and .execution files which are shown in the Test Navigator but don't use BaseEditorPart. So that means "Link With Editor" doesn't work for Reports or Test Log Viewer. It seems like work is being done in this area, so I think it should be implemented in such a way that doesn't restrict itself to BaseEditorPart. I have limited experience with such implementation but I found an article which describes how to register a part listener with the workbench page to achieve "Link With Editor" behavior. Here's the article: http://eclipse.pookzilla.net/2006/10/link-to-editor.php Also, I want to mention the Test Navigator correctly brings an open editor to the front when its corresponding ProxyNode is selected. This even works for my editor. So, that aspect of link to editor works fine. It's just the other direction that doesn't work.
Will be included in the 4.4 plan. Please target to a 4.4 iteration.
Assigning target.
Fixed. Editor input is no longer needed to implement IFileEditorInput to be in sync with the test navigator if it is adaptable in IFile. (input.getAdapter(IFile.class) != null) Html nodes in the test navigator are not handled by link to editor since the input is not adaptable in IFile (this is also the case in the resource navigator).
Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release. Thanks.
Verified with the candidate driver.
I have reviewed the related 4.4 code changes Jerome made to TestNavigator. They look good and take care of the issue I raised in comment #8. Thanks!
Closing since verified by originator.
