Bug 145736 - [patch] Input dialog could use a combo for multi choice input request
Summary: [patch] Input dialog could use a combo for multi choice input request
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Kevin Barnes CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 33832 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-07 06:28 EDT by Brock Janiczak CLA
Modified: 2006-09-14 10:42 EDT (History)
2 users (show)

See Also:

Attachments
patch to org.eclipse.ant.ui (5.01 KB, patch)
2006-06-07 06:31 EDT, Brock Janiczak CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2006-06-07 06:28:45 EDT 
Version: 3.2.0
Build id: I20060519-1206

The current SWTInputHandler is a direct copy of the default handler supplied by ANT.  When you specify the validargs attribute on the Input task, the dialog will only allow you to type in one of the valid args.  Because it will only accept these valid values, it makes sense to present all of the options to the user in a combo and have them pick one.

Attached is a patch to org.eclipse.ant.ui that adds this behaviour.

While implementing this feature, i ran across something interesting about the input task.  You can specify a default value, but it will never be used for the multi choice case, as it doesn't allow you to select null or empty.  If this is ever fixed in ant, this input handler shouldn't require any extra changes.
Comment 1 Brock Janiczak CLA 2006-06-07 06:31:34 EDT 
Created attachment 43701 [details]
patch to org.eclipse.ant.ui

Patch to add combo for multi choice input requests
Comment 2 Darin Swanson CLA 2006-06-07 10:34:15 EDT 
Thanks Brock.
Consider in 3.3.
Comment 3 Darin Swanson CLA 2006-06-07 10:35:22 EDT 
*** Bug 33832 has been marked as a duplicate of this bug. ***
Comment 4 Darin Swanson CLA 2006-09-14 10:42:14 EDT 
Tested and released the changes.
Comment 5 Darin Swanson CLA 2006-09-14 10:42:38 EDT 
Please verify Kevin.