Bug 145557 - [WorkbenchParts] Content description label needs a hover
Summary: [WorkbenchParts] Content description label needs a hover
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P5 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, contributed
: 65138 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-06 11:32 EDT by Tod Creasey CLA
Modified: 2008-04-29 12:03 EDT (History)
5 users (show)

See Also:


Attachments
Screenshot with Windows Extra Large Fonts (5.69 KB, image/png)
2006-06-06 11:34 EDT, Tod Creasey CLA
no flags Details
Patch to call setToolTipText(String) on the workbench part's label. (1.64 KB, patch)
2007-08-29 11:25 EDT, Remy Suen CLA
no flags Details | Diff
Patch to set a tooltip to the content description's label control. (1.70 KB, patch)
2008-04-04 10:24 EDT, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-06-06 11:32:39 EDT
RC7

It is fairly easy for the top label in the Java Hierarchy View to get cut off with a large font. It needs a hover text so that the full text can be read.
Comment 1 Tod Creasey CLA 2006-06-06 11:34:03 EDT
Created attachment 43598 [details]
Screenshot with Windows Extra Large Fonts
Comment 2 Martin Aeschlimann CLA 2006-06-08 05:53:49 EDT
I assume you mean 'ProblemFilter, working..'.

I 100% agree, a tooltip should show the full label.
Moving to platform UI, this is WorkbenchPart.setContentDescription(String)
Comment 3 Paul Webster CLA 2006-09-28 15:18:00 EDT
Is this still a problem in 3.3?

PW
Comment 4 Karice McIntyre CLA 2006-09-28 15:44:02 EDT
yes - in 3.3 M2
Comment 5 Remy Suen CLA 2007-08-29 11:25:57 EDT
Created attachment 77263 [details]
Patch to call setToolTipText(String) on the workbench part's label.

I took the liberty of updating both 3.3's and the default's presentation. I am not sure if that was desirable or not.
Comment 6 Paul Webster CLA 2007-09-13 12:37:52 EDT
(In reply to comment #5)
> Created an attachment (id=77263) [details]
> Patch to call setToolTipText(String) on the workbench part's label.

When you hover over a editor tab, you already get a tooltip.  I'd like to see us use the same mechanism for views if possible.

PW
Comment 7 Remy Suen CLA 2007-09-13 12:41:11 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=77263) [details] [details]
> > Patch to call setToolTipText(String) on the workbench part's label.
> 
> When you hover over a editor tab, you already get a tooltip.  I'd like to see
> us use the same mechanism for views if possible.

So hovering over the CTabItem should display the content description if there is one and the view's name if not or what?
Comment 8 Paul Webster CLA 2007-09-13 12:45:55 EDT
(In reply to comment #6)
> When you hover over a editor tab, you already get a tooltip.  I'd like to see
> us use the same mechanism for views if possible.
>

Check out PartInfo and DefaultTabItem ... they seem to set the CTabItem tooltip

I'm not so sure about the behaviour, though.

Tod?

PW
Comment 9 Remy Suen CLA 2007-09-17 18:39:48 EDT
Rethinking about this, I don't think I agree with having the content description displayed as the CTabItem's tooltip. Well, assuming that's what comment #6 was implying. Paul, could you rephrase that comment? I'm kind of lost.

The reason I disagree is that for something like 'Call Hierarchy', having the content description be synchronized with the tab's tooltip kind of makes sense. However, hovering over the 'Plug-ins' view and seeing something like 'Filter matched 145 of 153 plug-ins.' is not beneficial to the user at all. Perhaps the org.eclipse.ui.views extension point could add a new tooltip attribute for specifying a tooltip or something, but right now, I don't think having the tooltip display what's in the content description is meaningful from a usability standpoint.
Comment 10 Boris Bokowski CLA 2008-02-15 00:16:12 EST
*** Bug 65138 has been marked as a duplicate of this bug. ***
Comment 11 Remy Suen CLA 2008-04-02 17:19:12 EDT
Was the original request for a tooltip on the part's tab itself or on the part's content description's label?
Comment 12 Markus Keller CLA 2008-04-03 04:53:52 EDT
> Was the original request for a tooltip on the part's tab itself or on the
> part's content description's label?

Tooltip on the part tab itself is already IWorkbenchPart#getTitleToolTip(). Therefore, the part tab tooltip cannot be used to show too long descriptions. I don't think comment 6 makes sense.

This bug is about how to show long IWorkbenchPart2#getContentDescription().

The original request was to just set a tooltip to the description label, but duplicates also suggested to make the description wrappable to 2+ lines (see also bug 93878 for other problems with wrapping toolbar).
Comment 13 Remy Suen CLA 2008-04-03 08:27:42 EDT
Paul and Tod, per Markus's comment 12 and my comment 9, are you two in agreement with us that only the SWT Label should have the content description "replicated" as its tooltip? If yes, I can proceed with respinning a patch since the attached one is probably horribly out of date with CVS HEAD.

For wrapping support, we can consider that in a separate patch (or maybe just take it up with bug 93878 and leave this alone)?
Comment 14 Tod Creasey CLA 2008-04-03 08:37:16 EDT
I don't think wrapping ever makes sense for descriptions - why would the user want to lose a line of content in exchange for a line of description?

The question is more about what is useful to the user? The hover is usually used to show the full value of a truncated String and it is the description that is truncated so we should put the hover there.

This is also a win for accessibility if a screen reader needs to read the full string when scraping the UI
Comment 15 Boris Bokowski CLA 2008-04-03 11:29:59 EDT
(In reply to comment #14)
> I don't think wrapping ever makes sense for descriptions - why would the user
> want to lose a line of content in exchange for a line of description?

It is quite common that there is space for two lines of text because of toolbar icons that take up the vertical space anyway.
Comment 16 Markus Keller CLA 2008-04-03 12:34:44 EDT
> I don't think wrapping ever makes sense for descriptions - why would the user
> want to lose a line of content in exchange for a line of description?

Description and content are separate pieces of information. The description is about the content, and it may be interesting to see what's shown inside the viewer (e.g. in the Synchronize view: which projects were synchronized). And the content area is scrollable but the description is not.

> For wrapping support, we can consider that in a separate patch (or maybe just
> take it up with bug 93878 and leave this alone)?

Yes, bug 93878 should fix wrapping for toolbar and content description. Sorry, I shouldn't have brought that up here.
Comment 17 Remy Suen CLA 2008-04-04 10:24:09 EDT
Created attachment 94852 [details]
Patch to set a tooltip to the content description's label control.

Paul, I can't seem to find anything useful on the r21 presentation. Actually, I don't even see a content description. Since setContentDescription(String) was added to WorkbenchPart in 3.0 and getContentDescription() was defined by the IWorkbenchPart2 interface in 3.0, I have good reason to believe that the r21 presentation does not support this.

WorkbenchPart#setContentDescription(String):
http://help.eclipse.org/stable/nftopic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/ui/part/WorkbenchPart.html#setContentDescription(java.lang.String)

IWorkbenchPart2#getContentDescription():
http://help.eclipse.org/stable/nftopic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/ui/IWorkbenchPart2.html#getContentDescription()
Comment 18 Paul Webster CLA 2008-04-04 11:19:16 EDT
I don't think the 2.1 presentation matters here.  The only users I could find was one subclass of org.eclipse.ui.internal.presentations.util.AbstractTabFolder


PW
Comment 19 Paul Webster CLA 2008-04-08 14:41:10 EDT
Released to HEAD >20080408
PW
Comment 20 Paul Webster CLA 2008-04-29 12:03:00 EDT
in I20080429-0100
PW