Bug 144393 - [Annotate] Cannot show CVS annotations for binary file in text editor
Summary: [Annotate] Cannot show CVS annotations for binary file in text editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-05-30 04:50 EDT by Markus Keller CLA
Modified: 2007-06-05 15:17 EDT (History)
0 users

See Also:

Attachments
Not a patch (1.66 KB, patch)
2007-03-23 10:28 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-05-30 04:50:27 EDT 
N20060529-0010

Create or find a text file that is checked into CVS as a binary file. Open the file in the text editor and choose context menu > Team > Show Annotation. A dialog asks whether you want to annotate the binary file. Say Yes.

=> expected: annotations should be shown in change bar (if that's the preference)
=> was: annotations only shown in Annotate view in CVS Repositories perspective
Comment 1 Markus Keller CLA 2007-03-13 12:18:46 EDT 
An example for such a file is /org.eclipse.pde.ui/plugin.xml from HEAD.
Comment 2 Krzysztof Daniel CLA 2007-03-23 10:28:43 EDT 
Created attachment 61826 [details]
Not a patch

In this attachment there is a couple of changes, that seems to fix the bug.

But I am not sure, if it is does not introduce another bugs.

Also, Annotations of remote files does not work well for me.

Michael, could you verify that (patch & annotations behavior) and eventually give me some hints?
Comment 3 Michael Valenta CLA 2007-03-26 11:56:26 EDT 
Actually, I think the provided patch is fine. We have code higher up that prompts to warn the user that some of the selected files are marked as binary and we have code lower down that will revert to using a text editor if the default editor is not a text editor. Therefore, the binary checks that you commented out are the right ones to remove.

Patch released.
Comment 4 Michael Valenta CLA 2007-05-01 10:18:20 EDT 
Verified in I20070501-0010