Bug 143992 - Deprecate the org.eclipse.core.commands.util package and mark for deletion
Summary: Deprecate the org.eclipse.core.commands.util package and mark for deletion
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.11 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 572014
  Show dependency tree
 
Reported: 2006-05-26 12:54 EDT by Tod Creasey CLA
Modified: 2021-03-17 05:30 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-05-26 12:54:11 EDT 
RC5

org.eclipse.core.commands.util is marked as public but it is only used for debugging. We should move the tracing class and make the package only visible to JFace and the Workbench.
Comment 1 Lars Vogel CLA 2019-01-09 04:16:09 EST 
I suggest that we mark the package as x-internal. This should be similar to our current removal strategy only that do not delete the package. 

If we do this, this needs to be added to the migration guide.
Comment 2 Lars Vogel CLA 2019-01-09 04:16:52 EST 
Dani, Alex, any concerns?
Comment 3 Eclipse Genie CLA 2019-01-09 04:31:30 EST 
New Gerrit change created: https://git.eclipse.org/r/134827
Comment 4 Dani Megert CLA 2019-01-09 11:48:29 EST 
(In reply to Lars Vogel from comment #1)
> I suggest that we mark the package as x-internal. This should be similar to
> our current removal strategy only that do not delete the package. 
This is like deleting the API - a no go.

There is no shortcut. The specified process has to be followed, i.e. copy the functionality in an internal package and deprecate the API. Later mark it for deletion.
Comment 5 Lars Vogel CLA 2019-01-09 11:54:26 EST 
IMHO it is not the same as deleting, let's discuss in the next PMC call.
Comment 6 Dani Megert CLA 2019-01-09 12:07:12 EST 
(In reply to Lars Vogel from comment #5)
> IMHO it is not the same as deleting, let's discuss in the next PMC call.

It means the API is no longer API. The clients will not get a compiler error but an API Tools error. Also, it is not very clean to mark a package that does not have 'internal' in the name as internal. The proposed approach is just sloppy.
Comment 7 Lars Vogel CLA 2019-01-14 03:50:30 EST 
(In reply to Dani Megert from comment #6)
 
> It means the API is no longer API. The clients will not get a compiler error
> but an API Tools error. Also, it is not very clean to mark a package that
> does not have 'internal' in the name as internal. 

Ok, lets move it to an internal package. Feels also better to me.
Comment 8 Eclipse Genie CLA 2019-02-05 08:46:53 EST 
New Gerrit change created: https://git.eclipse.org/r/136305