Bug 143207 - [CommonNavigator] Unwanted error log entry with Common Navigator and Tabbed Properties
Summary: [CommonNavigator] Unwanted error log entry with Common Navigator and Tabbed P...
Status: RESOLVED DUPLICATE of bug 244354
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2006-05-23 09:39 EDT by Max Rydahl Andersen CLA
Modified: 2009-03-07 04:23 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Rydahl Andersen CLA 2006-05-23 09:39:39 EDT
While working with Common Navigator I got the following error in the Error Log:

Contributor org.hibernate.eclipse.navigator.KnownConfigurationsViewer cannot be created

from the plugin: org.eclipse.ui.views.properties.tabbed

And this happen even though I haven't done or defined anything in relationship to the properties view.

I assume it is something occurring because of CN calling into the properties setup, but do not know for sure.

Michael D. Elder wrote on the newsgroup:
"The CN framework has integration with the Tabbed Properties View built in. It's my impression that the error your seeing simply indicates that the 
Tabbed Properties View tried to create a contributor (to it) using the id of the view part, and was unsuccessful (e.g., no contributor to
the Tabbed Properties View is available with that id). I don't believe
it actually indicates an error condition."
Comment 1 Michael D. Elder CLA 2006-05-23 10:12:24 EDT
Anthony -- can you confirm that this error message is not an issue in this scenario and consider removing it?
Comment 2 Anthony Hunter CLA 2006-05-23 10:58:40 EDT
If you do not have a properties view for your viewer, you need to override the getAdapter() to not use the tabbed properties view.

As you code exists now, you are saying to use the tabbed properties view with id org.hibernate.eclipse.navigator.KnownConfigurationsViewer , which is the id of the view.
Comment 3 Michael D. Elder CLA 2006-05-23 11:09:18 EDT
In this case, it is the default implementation of the view part (org.eclipse.ui.navigator.CommonNavigator). The view part class uses the ID of the viewer when looking for a tabbed properties view provider. I would really rather not contribute a wholly separate default implementation without Tabbed Properties View support. Is there some middle ground here?

Comment 4 Anthony Hunter CLA 2006-05-23 11:17:21 EDT
Perhaps we should change getContributorId() in the base to return "org.eclipse.ui.navigator.CommonNavigator" and not getSite().getId().

Then extenders would get the default properties view configuration defined for the CommonNavigator.
Comment 5 Michael D. Elder CLA 2006-05-23 11:24:34 EDT
Remember that a "Common Navigator" is a type of viewer, not a specific viewer. There are at least two "Common Navigator"s provided in the Platform (the Team Synchronize views and the Project Explorer). In addition, other products that build on the Platform may have their own viewer instances for customized applications (indeed I know of two instances). These views may end up rendering some of the same things (Projects are a good example), so I think this could lead to a bad user experience where many properties that are not applicable in a certain context are exposed to the user. 

Comment 6 Anthony Hunter CLA 2006-05-23 11:30:21 EDT
ok, how about this.

Since org.hibernate.eclipse.navigator.KnownConfigurationsViewer is using the tabbed properties view with id org.hibernate.eclipse.navigator.KnownConfigurationsViewer , the best way to get rid of the error message is to simply add the propertyContributor extension point with nothing in it and you will get the "Properties are not available" in the properties view.

The customer should add this to plugin.xml 
<extension point="org.eclipse.ui.views.properties.tabbed.propertyContributor">
      <propertyContributor contributorId="org.hibernate.eclipse.navigator.KnownConfigurationsViewer "/>
</extension>
Comment 7 Michael D. Elder CLA 2006-07-19 16:29:08 EDT
Not significant enough to justify a fix for 3.2.1.
Comment 8 Francis Upton IV CLA 2008-08-26 04:39:37 EDT
Hi Max (or Rob), can you see if this is happening in build 3.4.1?  There were some fixes in this area that I think might have resolved this.
Comment 9 Francis Upton IV CLA 2009-03-07 04:23:49 EST

*** This bug has been marked as a duplicate of bug 244354 ***