Bug 142170 - [rulers] Annotations are not repainted upon state changes
Summary: [rulers] Annotations are not repainted upon state changes
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.2 RC5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
: 141053 142167 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-05-17 05:08 EDT by Anton Leherbauer CLA
Modified: 2006-05-22 10:27 EDT (History)
5 users (show)

See Also:

Attachments
Fix (1.62 KB, patch)
2006-05-17 05:45 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2006-05-17 05:08:14 EDT 
The fix to bug 132445 (3.2M6) breaks the repainting of breakpoints (and other marker annotations) if their state changes, because marker deltas other than location changes won't trigger model change events any longer. Please see also bug 139141, bug 141053 and bug 142167.
JDT seems to be less affected, probably because there is usually some background work going on, which triggers annotation painting.
Comment 1 Dani Megert CLA 2006-05-17 05:22:08 EDT 
Can you explain how the changes to bug 132445 should have affected this?
Comment 2 Anton Leherbauer CLA 2006-05-17 05:27:10 EDT 
(In reply to comment #1)
> Can you explain how the changes to bug 132445 should have affected this?

The relevant change is in ResourceMarkerAnnotationModel.update:

    case IResourceDelta.CHANGED :
+       if (hasLocationChanged(delta))
            modifyMarkerAnnotation(delta.getMarker());
        break;

When I remove the if, everything works as expected.
Comment 3 Dani Megert CLA 2006-05-17 05:42:09 EDT 
good catch!
Comment 4 Dani Megert CLA 2006-05-17 05:43:13 EDT 
*** Bug 141053 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA 2006-05-17 05:43:29 EDT 
*** Bug 142167 has been marked as a duplicate of this bug. ***
Comment 6 Dani Megert CLA 2006-05-17 05:45:18 EDT 
Created attachment 41706 [details]
Fix
Comment 7 Dani Megert CLA 2006-05-17 05:50:05 EDT 
Comment on attachment 41706 [details]
Fix

The fix reveals bug 132445 again.
Comment 8 Dani Megert CLA 2006-05-17 07:11:57 EDT 
At this point the safest fix is to simply revert the change that was done to fix bug 132445 and reopen it. Bug 132445 is in since 1.0 and a minor issue.

Mike, Martin, Philippe please cast your vote.
Comment 9 Mike Wilson CLA 2006-05-17 07:41:29 EDT 
+1
Comment 10 Martin Aeschlimann CLA 2006-05-17 08:05:38 EDT 
+1
Comment 11 Philipe Mulet CLA 2006-05-17 08:58:16 EDT 
+1 for 3.2RC5
Comment 12 Dani Megert CLA 2006-05-17 09:10:51 EDT 
Fixed in HEAD.
Reviewed by Tom and Markus.
Comment 13 Anton Leherbauer CLA 2006-05-17 09:42:32 EDT 
That was quick! Thanks.
Comment 14 Tom Hofmann CLA 2006-05-19 09:28:25 EDT 
Verified that the old behavior is there again. Verified that bug 132445 is not again reproducable with I20060519-0010.
Comment 15 Anton Leherbauer CLA 2006-05-22 10:24:30 EDT 
(In reply to comment #3)
> good catch!

The proper wording nowadays is "great bug" ;-)
Comment 16 Dani Megert CLA 2006-05-22 10:27:28 EDT 
Indeed!