Bug 141840 - Modify existing TPTP GLA adapters to provide filtering support at the GLA sensor level
Summary: Modify existing TPTP GLA adapters to provide filtering support at the GLA sen...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP.monitoring (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dave Smith CLA
QA Contact:
URL: http://www.eclipse.org/tptp/groups/Ar...
Whiteboard: closed460
Keywords: Documentation, PII, plan
Depends on: 157134
Blocks:
  Show dependency tree
 
Reported: 2006-05-15 14:21 EDT by Eric Labadie CLA
Modified: 2010-06-03 15:07 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Labadie CLA 2006-05-15 14:21:26 EDT
Provide GLA sensor level filtering for each TPTP GLA adapters so the performance can be improved at the File->Import timeframe
Comment 1 Eric Labadie CLA 2006-05-15 14:22:18 EDT
Please make this a P1 for 4.3
Comment 2 Dave Smith CLA 2006-05-23 11:06:19 EDT
Changing to the correct component and owner.

This feature requires creating filter exit classes for the existing TPTP GLA parsers.

Note, for the log import scenario, this feature is dependent on the Log Import Wizard passing the filter criteria to the adapter.
Comment 3 Dave Smith CLA 2006-05-23 11:06:52 EDT
Changing priority to P1 as requested.
Comment 4 Eric Labadie CLA 2006-05-30 18:47:41 EDT
JStart team has developed this feature and used for several customers. Filtering in LTA does not give time benefit. This is done at the sensor, and hence events outside of a time range are not completely parsed. The filters we have in the LTA today don't really give you any performance benefit.

A link to the developer works article on this (contains sample code also): http://www-128.ibm.com/developerworks/autonomic/library/ac-time/index.html

The list of specific adapters that support this capability should be equivalent to the list of adapters that need static parsers in TPTP.
Comment 5 Marius Slavescu CLA 2006-05-31 00:09:19 EDT
(In reply to comment #4)
> Filtering in LTA does not give time benefit. This is done at the sensor, and
> hence events outside of a time range are not completely parsed. The filters we
> have in the LTA today don't really give you any performance benefit.
I wouldn't say that the filters are the problem, I doubt that the result generated by the JStart team approach is always the correct one, I think they make the assumtion that the log entries are always in creation time order. Also I think (althogh I haven't looked at their code) that their implementation is written to optimize only this specific problem.

If we implement this feature we need to let the user choose the behavior, stop at first event that happend after the selected range. I also think that instead of only one range the user should be able to specify multiple ranges (we should avoid overlapped ranges in the UI filter builder) with including/exluding rules.

Instead of making this improvment only for creation time attribute we should handle in the same way any other attribute (not necessarly those that could be used in range expressions). 

Basically if a filter is provided the features values should be checked on the fly as the raw data is parsed, an example of such incremental evaluation mechanism is avaialble in the Import profile file filtering engine which is based on SimpleSearchEngine. 

As we tend to move to XPath filtering (in all areas) we could probably enhance the FastXPath engine with such incremental evaluation behavior and use it in GLA.








Comment 6 Eric Labadie CLA 2006-05-31 11:11:47 EDT
The filter should be based on:

-Time range
-Severity
-Filter on String included in the Log Record
Suggested filter format: XPATH
Comment 7 Dave Smith CLA 2006-06-22 03:35:53 EDT
Add description document.
Comment 8 Dave Smith CLA 2006-06-22 09:39:45 EDT
Adding plan keyword as it has been approved as a candidate for TPTP 4.3. 
Resources are available to complete this work.

Added documentation and PII keywords because the filter exit class may generate new messages and the feature should be documented.
Comment 9 Valentina Popescu CLA 2006-07-17 13:53:56 EDT
Reviewed and approved by the AG on July 14
Comment 10 Dave Smith CLA 2006-08-18 03:34:10 EDT
This is targetted to complete in 4.3 iteration 2 (Code complete Sept. 8)
Comment 11 Dave Smith CLA 2006-09-18 03:07:06 EDT
Code changes were committed to TPTP Head CVS.

New filter exit interfaces and abstract classes added:

org.eclipse.hyades.logging.adapter.util.ISeverityFilterExit
org.eclipse.hyades.logging.adapter.util.ITimeFilterExit
org.eclipse.hyades.logging.adapter.util.AbstractXPATHFilterExit

New filter exit class implementations added:

org.eclipse.hyades.logging.parsers.util.ApacheAccessLogFilterExit
org.eclipse.hyades.logging.parsers.util.ApacheErrorLogFilterExit
org.eclipse.hyades.logging.parsers.util.CommonBaseEventXMLLogFilterExit
org.eclipse.hyades.logging.parsers.util.JavaLoggingXMLLogFilterExit
org.eclipse.hyades.logging.parsers.util.WindowsEventLogFilterExit

Comment 12 Paul Slauenwhite CLA 2009-06-30 13:15:04 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.