Community
Participate
Working Groups
Many action items (Start, Stop, Attach, Detach, Terminate, Pause, Resume, Open with, and the views themselves) in the TPTP profiling context menu do not have shortcut keys attached to them. These shortcuts are necessary for accessibility purposes.
Re-targeting to 4.4.
Target to future. Cannot be contained in 4.4 due to limitation of resource.
translation changes needed in i6
Just a reminder that this fix is needed by 3/21
Created attachment 93626 [details] Proposed Patch Sorry for the lateness in this patch. But this should hopefullly be everything that is needed for the shortcuts to work. I have changed the structure a little it and have added a couple of files. There is only one handler in use for the various instances of the action items that re created and it seems to work fine for all. The problem of action items being used even if they were supposed to be disabled is also resolved.
The following shortcut combo seems to be available, please update you patch as possible. The multiple keys combo is not useful for user. Ctrl+M Start monitoring Ctrl+N Pause monitoring Ctrl+D Detach Ctrl+R Attach Ctrl+T Terminate Ctrl+G Run GC Ctrl+R Refresh
Created attachment 93897 [details] Patch This patch resolves the all ious outstanding issues. All keys work properly now. Most keys have been shortened, but it still has two modifiers ahead of it CTRL+ALT+<key>
Created attachment 93999 [details] Proposed Patch
Sorry I had forgotten to include the keys on Heap Dump action in the previous patch. This final patch is working fine for the following actions: Pause (Ctrl Alt P) Start (Ctrl Alt S) Attach (Ctrl Alt A) Detach (Ctrl Alt D) Refresh Views (Ctrl Alt R) Refresh Options (Ctrl Alt O) Run Garbage Collection (Ctrl Alt Shift G) Heap Dump (Collect Object References) (Ctrl Alt Shift O) I just tested on the 03/28 driver qith patch applied on latest CVS code and everything seems to work fine.
The patch contains errors in it. The wrong GC action is used for TI agent, and there is memory leak in actions and handlers. I will update and create the missing parts and attach a new patch here.
Created attachment 94264 [details] Patch! Sorry about the RunGCControlItem :(. I have restored the correct Garbage Collection for TI and PI agents. Also I have remocved the many Handler classes and created one ControlItemHandler which generates handlers for all the IControlItem Actions. That should save a bit of space. I've removed the context from the patch, but it seems the keys will not be active if it switches from the Profiling Navigator to one of the views :(. However, that only happens if the user selcts something like Heap Dump or Garbage Collection. The focus does not change with all action items.
Is this patch ready for inclusion in i6? or should it be deferred to i7?
Hi Ritwik, Ehe patch does not work for Run GC on PI agent. As discussed, the Run GC actions of TI and PI share the same key binding should have its own extension and not sharing the same action ID. They should be treated as two implementations of the same command id. All other action bindings seem to be okay. Joanna, I propose to defer this to i7.
Created attachment 95401 [details] Patch
The patch does not work when I have both TI and PI agent running at the same time.
Deferral to future with PMC approval
Update priority field to P2.
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
