Bug 140121 - [misc] The horizontal width and font of the error message in "Set Encoding" dialog is too small
Summary: [misc] The horizontal width and font of the error message in "Set Encoding" d...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-05-04 04:12 EDT by Hiroyuki Inaba CLA
Modified: 2006-09-07 05:08 EDT (History)
0 users

See Also:

Attachments
EncodeDialog.PNG (23.90 KB, image/png)
2006-05-07 00:42 EDT, Hiroyuki Inaba CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroyuki Inaba CLA 2006-05-04 04:12:32 EDT 
The horizontal width of the error message in "Set Encoding" dialog  is small.

Please fix as following

In org.eclipse.ui.editors plug-in
src/org/eclipse/ui/texteditor/MessageDialogPage.java

In public void createControl(Composite parent) method

	public void createControl(Composite parent) {
		Composite composite1= new Composite(parent, SWT.NONE);
		GridLayout layout = new GridLayout();
		layout.marginWidth = 0;
		layout.marginHeight = 0;
		composite1.setLayout(layout);
INSERT=>	composite1.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
		fMessageRegion= new MessageRegion();
		fMessageRegion.createContents(composite1);
		GridData messageData= new GridData(GridData.FILL_HORIZONTAL | GridData.GRAB_HORIZONTAL);
		fMessageRegion.setMessageLayoutData(messageData);
		setControl(composite1);
		
INSERT=>	org.eclipse.jface.dialogs.Dialog.applyDialogFont(composite1);
	}
Comment 1 Dani Megert CLA 2006-05-05 17:49:15 EDT 
What's the problem with the width?
Comment 2 Dani Megert CLA 2006-05-05 17:49:46 EDT 
Which build are you using?
Comment 3 Hiroyuki Inaba CLA 2006-05-06 12:25:20 EDT 
> What's the problem with the width?

YES.

But, there was another one problem. 
Dialog font not apply to message text.

I use 3.2 RC2.
Comment 4 Hiroyuki Inaba CLA 2006-05-07 00:42:27 EDT 
Created attachment 40559 [details]
EncodeDialog.PNG

Please see attachment
Comment 5 Dani Megert CLA 2006-05-08 08:40:56 EDT 
Good catch
Comment 6 Dani Megert CLA 2006-07-31 11:08:40 EDT 
Fixed in HEAD.
Available in builds > 20060731-0010.