Bug 13932 - Commit prompts about unsaved changes when there are none
Summary: Commit prompts about unsaved changes when there are none
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: James Moody CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 14114 143595 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-04-16 15:30 EDT by Nick Edgar CLA
Modified: 2006-05-25 18:19 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-04-16 15:30:17 EDT 
Build 20020412

- made a change to a file
- did a sync
- it showed as a conflict (correctly)
- merged the other changes in (using the toolbar button for copy current 
change from right to left)
- chose Save from context menu
- looked at another file's changes (no prompt to save)
- selected first file and chose Commit
- it prompted me:
Save Changes
You have unsaved changes that will be saved before the action is performed.
OK / Cancel
- I was pretty sure I had saved the changes before, so I canceled
- checked context menu: Save was disabled
- clicked on the other file again: no prompt
- tried Commit again
- got the prompt again
- hit OK
- it committed the changes
Comment 1 Nick Edgar CLA 2002-04-16 15:31:53 EDT 
It also kept prompting me on subsequent commits, even for files to which I had 
made no changes.
Comment 2 Nick Edgar CLA 2002-04-16 15:34:24 EDT 
And it kept doing it even when I switched to Incoming mode.
Comment 3 James Moody CLA 2002-04-16 15:59:52 EDT 
I saw this too. Should fix for M6.
Comment 4 James Moody CLA 2002-04-18 11:46:26 EDT 
*** Bug 14114 has been marked as a duplicate of this bug. ***
Comment 5 Jeff Brown CLA 2002-04-23 12:59:31 EDT 
Cannot do a perfect job of fixing this until Bug#14378 is fixed
since there is no precise way of determining when the contents
of the underlying CompareEditorInput in the SyncView are dirty.

The same workaround as for Bug#12010 applies here.
Comment 6 James Moody CLA 2002-04-29 13:34:11 EDT 
Closing. The bug has been fixed by reverting behaviour. Further improvements can
be made when the compare bug is fixed, but it is not blocking us from fixing
this one.
Comment 7 Mik Kersten CLA 2006-05-25 18:19:12 EDT 
*** Bug 143595 has been marked as a duplicate of this bug. ***