Bug 138942 - Compile errors against foundation 1.0: org.eclipse.update.ui
Summary: Compile errors against foundation 1.0: org.eclipse.update.ui
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Branko Tripkovic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 139490
  Show dependency tree
 
Reported: 2006-04-27 11:02 EDT by DJ Houghton CLA
Modified: 2006-05-04 08:27 EDT (History)
2 users (show)

See Also:

Attachments
patch for org.eclipse.update.ui (10.90 KB, patch)
2006-05-02 11:51 EDT, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2006-04-27 11:02:52 EDT 
build n0426

When compiling the org.eclipse.update.ui plug-in against the Foundation 1.0 class libraries we get the following errors.


The method encode(String) in the type URLEncoder is not applicable for the arguments (String, String)
org.eclipse.update.ui/src/org/eclipse/update/internal/ui
UpdateUI.java
line 337

The method replaceAll(String, String) is undefined for the type String
org.eclipse.update.ui/src/org/eclipse/update/internal/ui/properties
FeatureGeneralPropertyPage.java
line 163

The method getRequestingHost() is undefined for the type UpdateManagerAuthenticator
org.eclipse.update.ui/src/org/eclipse/update/internal/ui/security
UpdateManagerAuthenticator.java
line 26

The method decode(String) in the type URLDecoder is not applicable for the arguments (String, String)
org.eclipse.update.ui/src/org/eclipse/update/internal/ui/wizards
NewUpdateSiteDialog.java
line 158
Comment 1 Branko Tripkovic CLA 2006-04-27 12:13:54 EDT 
DJ, Jeff
this methods are in jdk 1.4 and code has been in for very long time, some of it from 2004. It might be very dangerous to change it this late. I am not sure how this was not caught before.
Comment 2 DJ Houghton CLA 2006-05-01 10:13:42 EDT 
The statement "compiles against Foundation 1.0" was never enforced before. Now the infrastructure is there and we can actually do it as part of the build process.
Comment 3 Jeff McAffer CLA 2006-05-01 22:49:46 EDT 
true that the slick way of doing this is recent but the manual way of confirming your plugin compiles against Foundation has been around for some time (since 3.0).

Having said that, we are where we are.  Lets see if we can fix the code for 3.2.
Comment 4 DJ Houghton CLA 2006-05-02 11:51:00 EDT 
Created attachment 40050 [details]
patch for org.eclipse.update.ui

Recommended patch for the org.eclipse.update.ui project. Note that this patch also combines the changes required to fix bug 139490.
Comment 5 Branko Tripkovic CLA 2006-05-03 12:10:26 EDT 
after applying patch I am getting an error in manifest.mf on this import packages:

Import-Package: javax.xml.parsers,
 org.w3c.dom,
 org.xml.sax,
 org.xml.sax.helpers

I am also confused with multiple environments is that ok:
Bundle-RequiredExecutionEnvironment: J2SE-1.4,
 CDC-1.0/Foundation-1.0,
 J2SE-1.3
Is this what you wanted:
Bundle-RequiredExecutionEnvironment: CDC-1.0/Foundation-1.0,
 J2SE-1.3

DJ, can you look at this please?
Also can you please combine patch with patch for 139490?
There is a same problem in patches for this bugs: bug 139490, bug 139489, bug 139488.
Comment 6 DJ Houghton CLA 2006-05-03 14:35:58 EDT 
What errors do you get? I re-applied the patch and it works fine for me. 

The patch is already combined with bug 139490.

The EE list is what we want. We need 1.4 first because that is the EE that the releng builder uses to compile against and we need to get the XML APIs from 1.4 for the build.
Comment 7 Branko Tripkovic CLA 2006-05-03 15:09:37 EDT 
DJ, sorry this was a clash between me and pde everything is fine now.
Jeff, Dejan I need some pluses here.
Comment 8 Dejan Glozic CLA 2006-05-03 19:55:25 EDT 
One more, Wassim - I can see the light at the end of the tunnel now :-).
Comment 9 Dejan Glozic CLA 2006-05-03 19:55:39 EDT 
+1 from me.
Comment 10 Wassim Melhem CLA 2006-05-03 19:57:21 EDT 
+1
Comment 11 Branko Tripkovic CLA 2006-05-04 08:27:45 EDT 
Committed.