Community
Participate
Working Groups
There are several issues using the compare editor to get a revision: 1) Confusion when getting something different than chosen 2) I always have to wait until the files are compared until I can choose a revsion 3) I can't double-click on a revision to get it 4) Editor always stays after choosing my revision - I have to manually close it
I use the resource history view for this workflow.
Actually I have to agree that our use of an editor for the replace with revision is weird. 1. why does replace with history show the compare in a dialog but replace with revision shows in editor? 2. there are probably valid use-cases for both options though: editor allows you to replace, test or edit some code, then replace again without having to hit the server again. The problem with this workflow is that the editor doesn't update with changes made to the resource outside of the compare editor. 3. if it remains an editor, there should be a shortcut for "replace with this and close", or else there are way too many mouse clicks required.
post 2.0 to clean this up, we meant to but never found the cycles
Reopening
I stumbled across this, too (2.1). Actually I was about to enter a bug report, because i didn't really understand that this *was* the replace dialog and that I should use the context menu to replace the file. I suggest that at least the title bar be changed.
I also found the "get an editor when you expect a dialog" workflow non- intuitive for Replace With->Revision... I needed to release a previous revision of a class, so I know I have to load the previous revision into my workspace, and then synchronize to release. (There is probably a better or newer way to do this, but I am old, and I tried to do it the old way. I don't see how to do it from the resource history view). When the editor opened instead of the dialog I actually thought a bug had been introduced <g>. I tried to keep working anyhow, but popping up the context menu on the revision yielded "Get Contents" or "Get Sticky Revision" - neither of which sounded quite right. I tried "Get Contents", and saw that my class was marked as changed. I guess that's ok, but I would have expected the revision to be loaded into my workspace - I could have seen this from the label decorations. (At first, I didn't have the cvs label decorations turned on, so it seemed that nothing had happened. I thought perhaps the asterisk in the Revision column of the Structure Compare table would move to the other revision, but it didn't). To make matters even more confusing, I kept getting a cryptic "The file has been changed on the file system. Do you want to load the changes? yes/no" dialog. I had no idea whether I wanted "yes" or "no". I can't reliably replicate this, but it has something to do with opening several comparison editors by saying Replace With->Revision... again, and selecting "Get Contents" in one editor and closing another - or something like that. The bottom line is that while I did eventually release the old code (as a new revision - not exactly what I intended, but good enough), I kept feeling that I was getting further and further away from what I really wanted to do, which was simply to load-and-release the old revision. Can we make this process more streamlined? The Replace With->Local History... workflow is more intuitive. It is unfortunate that these two similar workflows are inconsistent.
I stumbled upon this and realized that I was already planning on addressing the editor/dialog/view usages in the CVS plug-in. This will make it into M8.
Fix released to HEAD as follows: - tried to harmonize our use of editors and views. there are cases when having a non modal compare/merge is useful, but for the most part you don't need it. - merge/compare with/replace with now will always show a dialog. - the replace with dialog has a replace button to replace with the current selected revision - compares and merges can be 'remembered' an made non-modal. the synchronize view can contain different participants for compare and merges. this is an option on the dialogs. - i didn't add the double click a revision to replace because that's already used to fetch the remote revision, instead just use the replace button. - we don't fetch file contents for the revisions until selected, this is to avoid a round-trip when opening the dialog.
Verified (bug 54854 has been entered for refinements)
