Bug 137879 - Unable to specify resources in zip filesystem
Summary: Unable to specify resources in zip filesystem
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 164809 (view as bug list)
Depends on: 134270
Blocks:
  Show dependency tree
 
Reported: 2006-04-21 02:04 EDT by Tianchao Li CLA
Modified: 2007-05-03 13:32 EDT (History)
2 users (show)

See Also:


Attachments
EFS UI Support (7.11 KB, patch)
2006-05-09 15:54 EDT, Tianchao Li CLA
no flags Details | Diff
Patch (38.87 KB, patch)
2006-11-03 14:20 EST, John Arthorne CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tianchao Li CLA 2006-04-21 02:04:50 EDT
How to repeat the problem:
1. Check out and compile the org.eclipse.ui.filesystem.examples plug-in.
2. Start runtime workspace. The following operations are in the runtime workspace.
3. Create a new project, e.g. TestZipFilesystem
4. Create a new file, in the wizard page, check "Link file to file system" and choose the file system as "Zip file".
5. Click on Browse... button and browse to a zip file in the local file system , choose OK.
6. Now, the file name field becomes "GettingStarted.zip", and the link to file system filed becomes "zip:/d:/Downloads/GettingStarted.zip".
7. On windows platform, an error message appeared ": is an invalid character in resource name zip:.". And the Finish button is grayed out.
   On linux platform, a warning message appear and say that the resource is not available in the workspace. The finish button works, though.
===========
8. In both cases, there is no way to choose a file in the zip as the linked resource. In other words, the UI does not treat the zip as a file system.

The memory file system has similar problem, i.e. there is no real UI support for these file systems.
Comment 1 Tianchao Li CLA 2006-05-09 15:48:08 EDT
I have just discovered that this bug is partially dependent on bug 134270.
Comment 2 Tianchao Li CLA 2006-05-09 15:54:02 EDT
Created attachment 40851 [details]
EFS UI Support

I have created a patch that fixes the buggy UI support for EFS in Eclipse 3.2. It is only tested on Linux, but possibly also works on windows.
This is however not a final solution. The real solution requires the filesystemSupport extension point be modified, and that is postphoned to Eclipse 3.3.
Comment 3 John Arthorne CLA 2006-05-09 16:55:40 EDT
 Tianchao, thank you very much for these patches.  Unfortunately it is too late to change this for 3.2 (our final planned release build is this week), but we need to improve the UI for the next release so your work is greatly appreciated.
Comment 4 John Arthorne CLA 2006-06-23 13:47:15 EDT
I'm going to mark this as a duplicate of bug 134270.  That bug contains a better patch with proposed API to make the linked resource case work properly. The patch in this bug is really just a workaround.

*** This bug has been marked as a duplicate of 134270 ***
Comment 5 John Arthorne CLA 2006-11-03 14:06:55 EST
Reopening
Comment 6 John Arthorne CLA 2006-11-03 14:08:51 EST
We should be able to allow links in different file systems, but there is some code in CreateLinkedResourceGroup and related classes that assume the local file system is being used.  I investigated this and came up with a patch that makes it work.
Comment 7 John Arthorne CLA 2006-11-03 14:20:18 EST
Created attachment 53226 [details]
Patch

Tod, with these changes I can create links to files in other file systems. Do you mind if I go ahead and release this post M3? There is no new or changed API.
Comment 8 Tod Creasey CLA 2006-11-03 14:31:19 EST
Go ahead. Note that we are not post M3 yet.
Comment 9 John Arthorne CLA 2006-11-03 17:03:13 EST
Fix released.
Comment 10 John Arthorne CLA 2006-11-17 11:00:10 EST
*** Bug 164809 has been marked as a duplicate of this bug. ***
Comment 11 John Arthorne CLA 2007-05-03 13:32:03 EDT
Marking verified