Bug 137315 - [Dialogs] Doubleclickable area to restore dialog size is often very small
Summary: [Dialogs] Doubleclickable area to restore dialog size is often very small
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2006-04-18 14:13 EDT by Markus Keller CLA
Modified: 2011-05-20 09:23 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-04-18 14:13:57 EDT
N20060418-0010

The responsive area to restore the original size of Eclipse dialogs (bug 116906) is now typically only a few pixels around the 'Help' button.

The problem could be that TrayDialog (and maybe others) adds an intermediate composite to the button bar, but Dialog#addRestoreSizeMouseListeners(..) does not dive into the button bar to add doubleclick listeners there.
Comment 1 Susan McCourt CLA 2006-04-18 15:08:18 EDT
Yes, this is getting annoying.  Will investigate for RC2.
Comment 2 Susan McCourt CLA 2006-04-19 16:13:25 EDT
fixed >20060419.
As suggested, changes to dialog layouts made since this was first implemented added nested composites inside button bars.  Dialog now drills down into the button bar and adds the listener to any nested composites found inside the button bar.
Comment 3 Tod Creasey CLA 2006-04-20 20:49:00 EDT
Susan looking at this fix it is not clear to me why caching the dialog font from the previous session helps you here (I am looking at the changes to dialog). I thought the issue was more that the expanded tray size was not the size we wanted to restore with - I don't see where you drill down when storing the settings.

Also recall we need McQs approval as this stage so he needs to be added to this bug.
Comment 4 Susan McCourt CLA 2006-04-21 14:19:41 EDT
Tod, it sounds as if you are looking at the wrong set of changes.   You were likely looking at the changes for bug #132821.  That is the fix that involves fonts, you can see the discussion there.

The changes for this bug are in the previous revision, marked with this bug number.  See Dialog.addRestoreSizeMouseListenerToComposites.

I'll cc McQ on the other bug as well, I had cc'ed MVM by mistake.

Comment 5 Susan McCourt CLA 2006-04-27 14:34:18 EDT
verified on N20060425-0010, Win XP using various resizable dialogs
- open resource dialog
- open type dialog
- preferences
- save as dialog
- generate getters/setters
- new project wizard
Comment 6 Karice McIntyre CLA 2006-05-23 10:46:36 EDT
*** Bug 143062 has been marked as a duplicate of this bug. ***
Comment 7 Philippe Ombredanne CLA 2006-09-01 21:22:37 EDT
I just discovered that newly re-introduced "feature" when someone pointed me to it.
I know that it is documented in the platform tips and tricks.

However, this is the most surprising UI behavior I have seen... at first I really thought that this "shrinking the wizard on double click behavior" was a bug. Most of the times, wizards are too small as default, even for most platform provided wizards.
Note that clicking on a disabled button in that area also triggers wizard's resizing.

Could it be possible at the minimum that some of the newly introduced method could be overriden, or that this really weird resizing behavior can be prohibited in some way?
Or just plain removed?

I cannot understand the value of that resizing, which seems not working perfectly in all case, or looks really badly surprising in any case...
It makes wizards plain weird, imho.

Cordially
Comment 8 Susan McCourt CLA 2006-09-04 14:47:11 EDT
would you mind reposting your comment in bug #140306?  I'd do it for you, but it will be clearer where it's coming from if you do so.  This bug is closed, but the other one remains open on this issue.  Note that in 3.3 M1 we changed the behavior so that it happens less often.  In 3.3 we will decide whether to continue with this idea or do something completely different.  The original requirement is that users need a way to resize a dialog/wizard to the default computed size.
Comment 9 Philippe Ombredanne CLA 2006-09-04 15:42:38 EDT
(In reply to comment #8)
> would you mind reposting your comment in bug #140306? 
Done