Bug 137148 - [Markers] Contributions to IMarker no longer show up on elements in the Problems View
Summary: [Markers] Contributions to IMarker no longer show up on elements in the Probl...
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
Depends on:
Blocks: 130234
  Show dependency tree
 
Reported: 2006-04-18 02:44 EDT by Lawrence Mandel CLA
Modified: 2006-05-01 14:18 EDT (History)
1 user (show)

See Also:

Attachments
Zip of plug-in to test this issue (4.33 KB, application/octet-stream)
2006-04-18 15:26 EDT, Tod Creasey CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Mandel CLA 2006-04-18 02:44:51 EDT 
I own function in WTP that contributes an action to IMarkers. In previous versions of Eclipse this function was available on errors and warnings displayed in the Problems View by right clicking and selecting the action. The action no longer shows up and it seems that the fix for bug 65464 that I opened for this same problem in the 3.0 time frame has crept back into the Problems View.

My contribution is done with the following snippet:
<objectContribution
objectClass="org.eclipse.core.resources.IMarker"
id="org.eclipse.wst.xml.validation.internal.core.nestederrorlist"
nameFilter="*">

Without delving too deep into the Problems View code it seems that I can get the functionality I want by specifying an objectClass of org.eclipse.ui.views.markers.internal.ProblemMarker. However this object class is internal. There should be a public way to provide actions on the errors and warnings displayed in the Problems View.
Comment 1 Tod Creasey CLA 2006-04-18 14:35:08 EDT 
This code was deleted in the 3.2 refactoring accidentally.
Comment 2 Tod Creasey CLA 2006-04-18 15:01:20 EDT 
This can be fixed by restoring the code Nick outlines in Bug 65464
Comment 3 Tod Creasey CLA 2006-04-18 15:04:36 EDT 
Mike

This is just code that got deleted that needs to be restored as it is causing a regression. Permission for RC2?
Comment 4 Mike Wilson CLA 2006-04-18 15:15:05 EDT 
Yes, please.
Comment 5 Tod Creasey CLA 2006-04-18 15:25:03 EDT 
Fixed in build >20060419. Lawrence if you could verify independantly I would be most grateful.

I am going to attach my test plug-in.
Comment 6 Tod Creasey CLA 2006-04-18 15:26:08 EDT 
Created attachment 38843 [details]
Zip of plug-in to test this issue
Comment 7 Lawrence Mandel CLA 2006-04-18 23:59:52 EDT 
I've verified the fix with the latest version of org.eclipse.ui.ide from head using a runtime workbench. I'll mark the bug as verified once I verify the fix in an Eclipse driver picked up by WTP.
Comment 8 Lawrence Mandel CLA 2006-04-19 00:00:27 EDT 
Thanks for the very quick turnaround on this bug Tod!
Comment 9 Tod Creasey CLA 2006-04-19 08:01:10 EDT 
And thanks for the quick verification.
Comment 10 Tod Creasey CLA 2006-04-20 13:01:55 EDT 
great bug Lawrence - especially the reference to the previous issue
Comment 11 Tod Creasey CLA 2006-04-26 07:37:18 EDT 
Verified in 20060425
Comment 12 Lawrence Mandel CLA 2006-05-01 14:18:55 EDT 
I've verified this fix on RC2. Closing bug.