Bug 136907 - Update site wizard: Finish button does not become enabled
Summary: Update site wizard: Finish button does not become enabled
Status: RESOLVED DUPLICATE of bug 132029
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P1 major with 1 vote (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Branko Tripkovic CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
: 137082 137408 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-15 09:05 EDT by Channing Walton CLA
Modified: 2006-07-13 04:02 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Channing Walton CLA 2006-04-15 09:05:00 EDT
OSX 10.4.6 on Intel
eclipse.buildId=I20060413-1718
java.version=1.5.0_06

The Updates wizard that shows new features on selected update sites, allowing you to install them, does not enable its Finish button after features have been selected to install.

There is nothing in the logs.

Channing
Comment 1 Philippe Ombredanne CLA 2006-04-15 13:27:48 EDT
Channing,
what specific update site were you trying to get to?
Could you list them?
Comment 2 Channing Walton CLA 2006-04-15 13:39:35 EDT
(In reply to comment #1)
> Channing,
> what specific update site were you trying to get to?
> Could you list them?

I cannot get any update site to work, I've tried Calisto and eclipse tools (http://eclipse-tools.sourceforge.net/updates/) both of which worked for me with 3.2M6
Comment 3 Wong Yuen Ho CLA 2006-04-15 17:48:51 EDT
on ppc as well.
Comment 4 Philippe Ombredanne CLA 2006-04-15 18:10:24 EDT
I think that this is confusing, but it does works for me.
you *need* to change the install location
May be this was new introduced in 3.2rc1?
It could be linked to bug 90630 ?
It does that on macos 1.4 on ppc too, btw, but not on windows.
Anyway, just change the install location which is a *good thing* imho, and you should be able to go through your update.
Comment 5 Philippe Ombredanne CLA 2006-04-15 18:12:39 EDT
oops.
It does not work either if you chnage the install location.
I was too quick to conclusion.
Please ignore comment #4
My mistake.
Comment 6 Philippe Ombredanne CLA 2006-04-15 20:07:13 EDT
I narrowed it down to size issues: on all pltaforms without natives  (that is everywhere except on win and lin) the patch applied in bug 132029 makes update IMPOSSIBLE. The size returned is always -1 by LocalSystemInfo. So update believes that there is no available space.

Since it is now enforced, that breaks update on all platforms but win and lin.

My suggestion: roll back the patch from bug 132029. Too late in the RC imho, unless you can provide reliable natives on all other platforms :-\ or find sme other magic.

And please mark this as a greatbug for Channing, even if I am not a committer.
And I give myself a pat in the back, cuz this is a greatfind :-).
And please raise that as a blocker.
Comment 7 Philippe Ombredanne CLA 2006-04-15 20:10:05 EDT
Channing and Wong: could you verify/test that the bug does not exist on 3.2M6?
It should not.
Comment 8 Philippe Ombredanne CLA 2006-04-15 21:05:59 EDT
A possible solution could be to check if a given OS has natives, and if not ignore the size check enforcement. 

As a side note, the only way I know of to get the free space in java is through natives of command line. At least until Java 6, which is supposed to have that supported.
That later approach is used by common-io:
http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/FileSystemUtils.html

That may sounds ugly, but it works.
See http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileSystemUtils.java?view=markup
And that would offer support for most if not all supported Eclipse platforms.

And could be an acceptable go-between until natives can be coded, and then thrown away when Java 6 becomes the mandatory eclipse ee.

And just for the fun of it:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4057701

Comment 9 Wong Yuen Ho CLA 2006-04-16 02:44:25 EDT
I can confirm that it doesn't appear in M6, this is indeed a very severe bug. I can't believe those brilliant minds at Eclipse.org missed this one. Please mark this as P1 and blocker and fix this before the final Callisto release I beg of you :).
Comment 10 Channing Walton CLA 2006-04-16 05:19:38 EDT
(In reply to comment #7)
> Channing and Wong: could you verify/test that the bug does not exist on 3.2M6?
> It should not.

The bug does not exist on 3.2M6 for me.

Thanks for finding it Philippe.
Comment 11 Philippe Ombredanne CLA 2006-04-16 13:57:43 EDT
Dejan,
Could you mark that as a great bug for Channing?
So he can entered in the contest ;-)
http://www.eclipse.org/projects/callisto-files/callisto-bug-contest.php
I think this is deserved as it fullfills both action and value!
Comment 12 Dejan Glozic CLA 2006-04-16 14:07:49 EDT
Sure, how do I do it?
Comment 13 Philippe Ombredanne CLA 2006-04-16 14:14:16 EDT
Dejan, you just need to add the greatbug keyword in the keyword field.
Comment 14 Dejan Glozic CLA 2006-04-16 14:15:57 EDT
Here it comes.
Comment 15 Dejan Glozic CLA 2006-04-16 14:17:29 EDT
Branko, we should not make computations that affect the Finish button if the available size cannot be computed.
Comment 16 Channing Walton CLA 2006-04-16 14:19:01 EDT
(In reply to comment #14)
> Here it comes.
> 

Thanks guys :-)
Comment 17 Dejan Glozic CLA 2006-04-18 21:07:03 EDT
*** Bug 137408 has been marked as a duplicate of this bug. ***
Comment 18 Dejan Glozic CLA 2006-04-18 21:08:41 EDT

*** This bug has been marked as a duplicate of 132029 ***
Comment 19 Dejan Glozic CLA 2006-04-18 21:25:44 EDT
*** Bug 137082 has been marked as a duplicate of this bug. ***
Comment 20 Channing Walton CLA 2006-07-13 04:02:06 EDT
(In reply to comment #11)
> Dejan,
> Could you mark that as a great bug for Channing?

:-) I won a mountain bike!!! Thanks for entering me.