Bug 136881 - JET override/inserts for ItemProvider.javajet
Summary: JET override/inserts for ItemProvider.javajet
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: 2.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dave Steinberg CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 141079 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-14 15:54 EDT by Patrick Sodre CLA
Modified: 2008-05-13 17:09 EDT (History)
2 users (show)

See Also:


Attachments
Override/Insert for collectNewChildDescriptors. (1.99 KB, patch)
2006-04-14 15:57 EDT, Patrick Sodre CLA
no flags Details | Diff
Override/Insert for adding Factories to the Editor. (1.09 KB, patch)
2006-04-14 16:00 EDT, Patrick Sodre CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Sodre CLA 2006-04-14 15:54:37 EDT
As suggested by Ed's post news://news.eclipse.org:119/e1o3kb$g0n$1@utils.eclipse.org

It would be nice to have more control over how the collectNewChildDescriptors
code is generated. Unfortunately, ItemControl.javajet does not have a single override/include. So I am posting this bug as a request for enchancement for that class.

I'll post my patches on what I found useful when solving the problem of Dynamically building the newChildDescriptors.
Comment 1 Patrick Sodre CLA 2006-04-14 15:57:58 EDT
Created attachment 38615 [details]
Override/Insert for collectNewChildDescriptors.

This will allow the user to override/insert code whenever a child feature is of type Reference.

It does not add any code to the CrossPackageCreateChildFeatures because I was not able to correctly identify what populates that collection.
Comment 2 Patrick Sodre CLA 2006-04-14 16:00:28 EDT
Created attachment 38616 [details]
Override/Insert for adding Factories to the Editor.

Although I know the Editor code is just a starting point and most likely the Constructor is going to be tagged @generated not, the following patch allows the user to override which ItemProviderFactories are added to the Editor.
Comment 3 Ed Merks CLA 2007-04-23 10:41:25 EDT
The changes have been committed to CVS.  I've added control over all the parts of the new child descriptor creation code and I've also moved the editor's constructor code to a separate method so that the code is easier to specialized using the "rename-to-Gen" approach.

This change includes contributed code from the patches.

[contrib email="psodre@gmail.com"/]
Comment 4 Ed Merks CLA 2007-04-24 11:43:40 EDT
*** Bug 141079 has been marked as a duplicate of this bug. ***
Comment 5 Nick Boldt CLA 2007-04-25 11:49:36 EDT
Fixed in I200704250200.
Comment 6 Nick Boldt CLA 2008-01-28 16:39:35 EST
Move to verified as per bug 206558.