Bug 135783 - need to adopt ICU4J APIs
Summary: need to adopt ICU4J APIs
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 127876
  Show dependency tree
 
Reported: 2006-04-09 23:07 EDT by Karice McIntyre CLA
Modified: 2006-04-11 15:23 EDT (History)
0 users

See Also:

Attachments
archive of patches for affected update projects (8.12 KB, application/zip)
2006-04-09 23:09 EDT, Karice McIntyre CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2006-04-09 23:07:10 EDT 
To complete the plan item to deliver ICU4J support in the Eclipse (see bug
127876) code must be migrated to use the com.ibm.icu.* classes in place of the
default java implementation.  This component is affected.  I will attach
patches with the changes required (only import changes at this point).  This
needs to be done for RC1.
Comment 1 Karice McIntyre CLA 2006-04-09 23:09:00 EDT 
Created attachment 38108 [details]
archive of patches for affected update projects

There is a patch file for each affected project, named accordingly.

Please review this changes - there are some changes made to classes in the /src_webapp directory that I am not certain should have been made.
Comment 2 Branko Tripkovic CLA 2006-04-11 11:58:08 EDT 
Changes committed. Thanks Karice. If I understood correctly you will have more patches with more changes, so I left this bug open.
Comment 3 Karice McIntyre CLA 2006-04-11 12:27:15 EDT 
There are no more patches to come in for update.  I should have been more clear in my last comment.  There is a java.util.* import that is removed in the update ui patch in class:
src_webapp/org/eclipse/update/internal/ui/servlets/ServletsUtil.java

Was this a bad thing to do?
Comment 4 Branko Tripkovic CLA 2006-04-11 15:01:22 EDT 
I took those changes out. I am closing this bug.
Comment 5 Karice McIntyre CLA 2006-04-11 15:14:21 EDT 
Can you append this bug with explanations of any changes you made to the patches and why they were done?  Just so we have a record of why this was done in case this comes up in the future.
Comment 6 Branko Tripkovic CLA 2006-04-11 15:23:02 EDT 
To the best of my knowledge this classes are not used anymore. They were experimentally used before 3.0. And since then the support on client side for them was taken out. We are considering deleting them. These classes also do not compile anymore. So I thought it's best to leave them alone for now.