Bug 135765 - need to adopt ICU4J APIs
Summary: need to adopt ICU4J APIs
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 127876
  Show dependency tree
 
Reported: 2006-04-09 19:47 EDT by Karice McIntyre CLA
Modified: 2006-04-18 12:18 EDT (History)
0 users

See Also:

Attachments
archive of patches for affected ant projects (3.92 KB, application/zip)
2006-04-09 19:48 EDT, Karice McIntyre CLA 		no flags Details
patch for org.eclipse.uiexternaltools (5.93 KB, patch)
2006-04-09 23:32 EDT, Karice McIntyre CLA 		no flags Details | Diff
patch for org.eclipse.ui.console (2.08 KB, patch)
2006-04-09 23:50 EDT, Karice McIntyre CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2006-04-09 19:47:12 EDT 
To complete the plan item to deliver ICU4J support in the Eclipse (see bug
127876) code must be migrated to use the com.ibm.icu.* classes in place of the
default java implementation.  This component is affected.  I will attach
patches with the changes required (only import changes at this point).  This
needs to be done for RC1.
Comment 1 Karice McIntyre CLA 2006-04-09 19:48:35 EDT 
Created attachment 38096 [details]
archive of patches for affected ant projects

There is a patch file for each affected project, named accordingly.
Comment 2 Karice McIntyre CLA 2006-04-09 23:32:13 EDT 
Created attachment 38113 [details]
patch for org.eclipse.uiexternaltools

I forgot to add the external tools stuff to this.  I believe it belongs with this component.  Correct me if I am wrong.
Comment 3 Karice McIntyre CLA 2006-04-09 23:50:38 EDT 
Created attachment 38117 [details]
patch for org.eclipse.ui.console

In going through my double check, it appears I also forgot to include the patch for org.eclipse.ui.console.  Here it is.
Comment 4 Darin Swanson CLA 2006-04-10 00:11:55 EDT 
Thanks.

Console UI is in the debug component but I happen to have commit rights there as well...
Comment 5 Darin Swanson CLA 2006-04-10 11:46:58 EDT 
Patches applied.
Comment 6 Darin Swanson CLA 2006-04-12 12:05:29 EDT 
verified.
Comment 7 Darin Swanson CLA 2006-04-18 12:18:48 EDT 
I have removed the reliance on ICU4J from org.eclipse.ant.core and org.eclipse.ui.external tools as all that was needed was NLS.bind.

Changes to the MANIFEST.MF of the 2 plugins and:
AntCorePreferences, and AntRunner.
ExternalToolsUtil, ExternalToolBuilder, BuildLabelProperty, BuildPropertyPage, BuildProjectResolver and ProgramLaunchDelegate