Bug 135709 - [WorkingSets] Select Working Sets Select All/Deselect All Enablement
Summary: [WorkingSets] Select Working Sets Select All/Deselect All Enablement
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2006-04-08 08:20 EDT by Sebastian Davids CLA
Modified: 2007-06-05 15:01 EDT (History)
0 users

See Also:

Attachments
fix (5.85 KB, patch)
2006-04-08 09:26 EDT, Sebastian Davids CLA 		no flags Details | Diff
patch against o.e.u.workbench (8.99 KB, patch)
2006-04-22 08:44 EDT, Sebastian Davids CLA 		no flags Details | Diff
patch against o.e.u.ide (4.52 KB, patch)
2006-04-22 08:45 EDT, Sebastian Davids CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Davids CLA 2006-04-08 08:20:52 EDT 
If there are no working sets than both buttons should be disabled.
Comment 1 Sebastian Davids CLA 2006-04-08 08:27:18 EDT 
Also:

the list does not use the dialog font
the space between the list and the buttons is non-standard
Comment 2 Sebastian Davids CLA 2006-04-08 09:26:47 EDT 
Created attachment 38077 [details]
fix

Converted abstract availableWorkingSetsChanged to hook method.

Different option would be to make the button IDs protected and use getButton(buttonId).
Comment 3 Sebastian Davids CLA 2006-04-22 08:44:53 EDT 
Created attachment 39240 [details]
patch against o.e.u.workbench

same as above but w/ additional layout tweaks
Comment 4 Sebastian Davids CLA 2006-04-22 08:45:22 EDT 
Created attachment 39241 [details]
patch against o.e.u.ide

layout tweaks
Comment 5 Kim Horne CLA 2006-08-14 13:34:20 EDT 
The patches didn't work in the case where the dialog came up with no working sets available - it only reacted when the set changed.  I've updated the patch and commited it.  Thanks!
Comment 6 Kim Horne CLA 2006-09-19 10:54:55 EDT 
Verified in  I20060918-2000