Bug 135568 - [CommonNavigator] Project Explorer performance
Summary: [CommonNavigator] Project Explorer performance
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-07 11:18 EDT by Jon Corchis CLA
Modified: 2019-09-06 16:16 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Corchis CLA 2006-04-07 11:18:06 EDT
I looked closely into the profiler report and I found these functions -among others- to take so much time, I mean other parts of the code (e.g., NavigatorContentService::findRelevantLableProviders(), or, NavigatorContentService::findDescriptorsWithPossibleChild()), rely on these functions to do their job:

	VisibilityAssistant::isVisible() 
	NavigatorContentDescriptor::isPossibleChild()
	NavigatorContentDescriptor.isTriggerPoint()
	NavigatorContentService::extractDescriptorInstances()
	NavigatorContentService::extractLabelProviders()

Moreover, the code in general rely on using WeakHashMap, which is much slower than normal maps, and on using TreeMaps which is also slower due to sorting and finally using AbstractCollection::AddAll(). Perhaps using these collections is unavoidable, however I just though I should let you know.

YL to provide more details.
Comment 1 Eric Moffatt CLA 2006-04-13 10:07:44 EDT
Yaser, do you have more details on this?
Comment 2 Yasser Lulu CLA 2006-04-19 12:31:22 EDT
Eric, I just profiled "expand-all" scenario and the functions mentioned in the first comment consume most of the time. I haven't looked at the code of these functions so I'm not really sure what could be done about them.
Comment 3 Michael D. Elder CLA 2006-07-27 15:40:58 EDT
Yassar -- could you test a patch to determine if we could improve the performance of VisibilityAssistant.isVisible() ? 
Comment 4 Tod Creasey CLA 2006-08-16 12:48:46 EDT
Is this still going into 3.2.1? We are going to release candiates next week.
Comment 5 Michael D. Elder CLA 2006-08-17 09:20:56 EDT
I'm apprehensive about releasing any non-specific performance fixes for 3.2.1. I am investigating some possible improvements, but none are stable enough at this point to release for 3.2.1. 
Comment 6 Boris Bokowski CLA 2006-09-05 23:28:50 EDT
Moving to 3.3.  See bug 155371 for another potential performance issue with the common navigator.
Comment 7 Boris Bokowski CLA 2009-05-06 16:48:47 EDT
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
Comment 8 Francis Upton IV CLA 2009-05-06 18:06:41 EDT
Missed because of bad title, fixing.
Comment 9 Francis Upton IV CLA 2010-03-09 02:55:27 EST
The WeakHashMap is no longer used.  This performance study is probably out of date due to all of the changes in the last couple of weeks.  At some point I will do a performance study; I'm sure there are opportunities.

This is not really a bug, btw as far as I'm concerning, making it an enhancement request.
Comment 10 Eclipse Webmaster CLA 2019-09-06 16:16:40 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.